Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2645853002: Allow more config changes for CallActivity. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow more config changes for CallActivity. CallActivity doesn't survive recreation so we have to handle these config changes. Fortunately, they don't seem to require any special handling. BUG=webrtc:7018 Review-Url: https://codereview.webrtc.org/2645853002 Cr-Commit-Position: refs/heads/master@{#16180} Committed: https://chromium.googlesource.com/external/webrtc/+/fd6c94d3114d3a3e5db262110735919c7da3571b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/examples/androidapp/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-19 14:31:21 UTC) #4
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-20 09:33:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2645853002/1
3 years, 11 months ago (2017-01-20 09:42:04 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:36:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fd6c94d3114d3a3e5db262110...

Powered by Google App Engine
This is Rietveld 408576698