Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2645343002: Don't update the jitter estimate with frames containing retransmitted packets. (Closed)

Created:
3 years, 11 months ago by philipel
Modified:
3 years, 11 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't update the jitter estimate with frames containing retransmitted packets. BUG=chromium:682636 Review-Url: https://codereview.webrtc.org/2645343002 Cr-Commit-Position: refs/heads/master@{#16273} Committed: https://chromium.googlesource.com/external/webrtc/+/e0754305aa8787c483c2a4fd319fa383b9bf1493

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : times_nacked() --> delayed_by_retransmission() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.cc View 1 2 3 4 1 chunk +12 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/frame_object.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/frame_object.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
philipel
3 years, 11 months ago (2017-01-23 11:22:34 UTC) #2
stefan-webrtc
https://codereview.webrtc.org/2645343002/diff/60001/webrtc/modules/video_coding/frame_object.h File webrtc/modules/video_coding/frame_object.h (right): https://codereview.webrtc.org/2645343002/diff/60001/webrtc/modules/video_coding/frame_object.h#newcode42 webrtc/modules/video_coding/frame_object.h:42: // TODO(philipel): Remove this function when new a new ...
3 years, 11 months ago (2017-01-24 13:03:14 UTC) #3
philipel
https://codereview.webrtc.org/2645343002/diff/60001/webrtc/modules/video_coding/frame_object.h File webrtc/modules/video_coding/frame_object.h (right): https://codereview.webrtc.org/2645343002/diff/60001/webrtc/modules/video_coding/frame_object.h#newcode42 webrtc/modules/video_coding/frame_object.h:42: // TODO(philipel): Remove this function when new a new ...
3 years, 11 months ago (2017-01-25 15:04:17 UTC) #4
stefan-webrtc
lgtm
3 years, 11 months ago (2017-01-25 15:05:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2645343002/80001
3 years, 11 months ago (2017-01-25 15:31:27 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 16:56:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/e0754305aa8787c483c2a4fd3...

Powered by Google App Engine
This is Rietveld 408576698