Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2645333002: Delete unused class CompositeMediaEngineWithFakeVoiceEngine. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 11 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused class CompositeMediaEngineWithFakeVoiceEngine. BUG=None Review-Url: https://codereview.webrtc.org/2645333002 Cr-Commit-Position: refs/heads/master@{#16230} Committed: https://chromium.googlesource.com/external/webrtc/+/dc2b3f3b9f694bfc738c491abb76ca1382c1c0e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M webrtc/media/base/fakemediaengine.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
PTAL. This appears unused, since the beginning of git history.
3 years, 11 months ago (2017-01-23 10:35:49 UTC) #2
perkj_webrtc
lgtm
3 years, 11 months ago (2017-01-23 20:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2645333002/1
3 years, 11 months ago (2017-01-24 07:41:03 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 08:55:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dc2b3f3b9f694bfc738c491ab...

Powered by Google App Engine
This is Rietveld 408576698