Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2645223003: Moving no_op_function.cc out of webrtc/build (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving no_op_function.cc out of webrtc/build BUG=webrtc:7030 Review-Url: https://codereview.webrtc.org/2645223003 Cr-Commit-Position: refs/heads/master@{#16246} Committed: https://chromium.googlesource.com/external/webrtc/+/b54c63ffb0191eb25ec0cead534bfcbe4f5cffe7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/build/no_op_function.cc View 1 chunk +0 lines, -23 lines 0 comments Download
A + webrtc/no_op_function.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
mbonadei
I read your TODO and tried to remove no_op_function.cc but it is still needed to ...
3 years, 11 months ago (2017-01-23 14:58:18 UTC) #2
kjellander_webrtc
On 2017/01/23 14:58:18, mbonadei wrote: > I read your TODO and tried to remove no_op_function.cc ...
3 years, 11 months ago (2017-01-24 06:50:58 UTC) #3
mbonadei
On 2017/01/24 06:50:58, kjellander_webrtc wrote: > On 2017/01/23 14:58:18, mbonadei wrote: > > I read ...
3 years, 11 months ago (2017-01-24 07:21:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2645223003/1
3 years, 11 months ago (2017-01-24 07:21:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12577)
3 years, 11 months ago (2017-01-24 07:25:55 UTC) #8
mbonadei
On 2017/01/24 07:25:55, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-24 07:29:42 UTC) #9
mbonadei
3 years, 11 months ago (2017-01-24 07:30:10 UTC) #11
stefan-webrtc
lgtm
3 years, 11 months ago (2017-01-24 13:00:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2645223003/1
3 years, 11 months ago (2017-01-24 13:22:59 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 13:25:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b54c63ffb0191eb25ec0cead5...

Powered by Google App Engine
This is Rietveld 408576698