Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2644863002: Reland of "Log audio network adapter decisions in event log." (Closed)

Created:
3 years, 11 months ago by minyue-webrtc
Modified:
3 years, 11 months ago
Reviewers:
the sun, terelius, michaelt
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of "Log audio network adapter decisions in event log." This was originally reviewed https://codereview.webrtc.org/2559953002/ It was reverted due to a bug in the original CL, see https://codereview.webrtc.org/2631703002/ This CL is to fix and reland. BUG=webrtc:6845 Review-Url: https://codereview.webrtc.org/2644863002 Cr-Commit-Position: refs/heads/master@{#16242} Committed: https://chromium.googlesource.com/external/webrtc/+/4b7c952376bec4797307b106796c5612d930f206

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : another fix #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -3 lines) Patch
M webrtc/logging/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 3 chunks +7 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.proto View 3 chunks +25 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 2 chunks +9 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 3 chunks +35 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 4 chunks +9 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc View 5 chunks +20 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/event_log_writer.h View 1 chunk +44 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/event_log_writer.cc View 1 chunk +68 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/event_log_writer_unittest.cc View 1 chunk +265 lines, -0 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (18 generated)
minyue-webrtc
https://codereview.webrtc.org/2644863002/diff/1/webrtc/logging/BUILD.gn File webrtc/logging/BUILD.gn (right): https://codereview.webrtc.org/2644863002/diff/1/webrtc/logging/BUILD.gn#newcode64 webrtc/logging/BUILD.gn:64: proto_in_dir = "//" This change is not needed and ...
3 years, 11 months ago (2017-01-19 11:35:33 UTC) #4
terelius
https://codereview.webrtc.org/2644863002/diff/20001/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2644863002/diff/20001/webrtc/modules/audio_coding/BUILD.gn#newcode891 webrtc/modules/audio_coding/BUILD.gn:891: proto_out_dir = "." Note that this is similar to ...
3 years, 11 months ago (2017-01-19 12:23:40 UTC) #7
minyue-webrtc
https://codereview.webrtc.org/2644863002/diff/20001/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2644863002/diff/20001/webrtc/modules/audio_coding/BUILD.gn#newcode891 webrtc/modules/audio_coding/BUILD.gn:891: proto_out_dir = "." On 2017/01/19 12:23:40, terelius wrote: > ...
3 years, 11 months ago (2017-01-19 12:46:13 UTC) #8
terelius
lgtm
3 years, 11 months ago (2017-01-19 12:59:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2644863002/40001
3 years, 11 months ago (2017-01-19 13:10:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12443)
3 years, 11 months ago (2017-01-19 13:14:19 UTC) #13
minyue-webrtc
Add "the sun" for VoE approval.
3 years, 11 months ago (2017-01-20 17:22:26 UTC) #15
michaelt
lgtm
3 years, 11 months ago (2017-01-23 15:21:52 UTC) #20
the sun
lgtm
3 years, 11 months ago (2017-01-24 08:32:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2644863002/60001
3 years, 11 months ago (2017-01-24 09:35:41 UTC) #24
minyue-webrtc
On 2017/01/24 08:32:26, the sun (OOO until Jan 30th) wrote: > lgtm I did not ...
3 years, 11 months ago (2017-01-24 10:49:32 UTC) #25
minyue-webrtc
On 2017/01/24 08:32:26, the sun (OOO until Jan 30th) wrote: > lgtm I did not ...
3 years, 11 months ago (2017-01-24 10:49:37 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/17947)
3 years, 11 months ago (2017-01-24 10:52:14 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2644863002/60001
3 years, 11 months ago (2017-01-24 12:36:43 UTC) #30
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 12:55:04 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/4b7c952376bec4797307b1067...

Powered by Google App Engine
This is Rietveld 408576698