Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2644603003: Revert of Move congestion controller processing to the pacer thread. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move congestion controller processing to the pacer thread. (patchset #5 id:80001 of https://codereview.webrtc.org/2637783003/ ) Reason for revert: Speculative revert for perf regression related to ramp-up on android. See https://bugs.chromium.org/p/chromium/issues/detail?id=682611 Original issue's description: > Move congestion controller processing to the pacer thread. > > Also rename it from pacer_thread_ to congestion_controller_thread_. > > BUG=webrtc:6847 > > Review-Url: https://codereview.webrtc.org/2637783003 > Cr-Commit-Position: refs/heads/master@{#16134} > Committed: https://chromium.googlesource.com/external/webrtc/+/b3dc2b7b1e02970c49064a61a4bd0fc941249c93 TBR=danilchap@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6847 Review-Url: https://codereview.webrtc.org/2644603003 Cr-Commit-Position: refs/heads/master@{#16163} Committed: https://chromium.googlesource.com/external/webrtc/+/b93598465d85a7df2f601058260eb2edc26b93ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M webrtc/call/call.cc View 4 chunks +12 lines, -7 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/modules/pacing/alr_detector.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nisse-webrtc
Created Revert of Move congestion controller processing to the pacer thread.
3 years, 11 months ago (2017-01-19 12:25:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2644603003/1
3 years, 11 months ago (2017-01-19 12:25:24 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 13:41:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b93598465d85a7df2f6010582...

Powered by Google App Engine
This is Rietveld 408576698