Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2644463009: New simulators to test BWE at low bitrates (15-50kbps range). (Closed)

Created:
3 years, 11 months ago by terelius
Modified:
3 years, 11 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

New simulators to test BWE at low bitrates (15-50kbps range). I've tested both the old and the new delay estimators and they all work ok at 15 kbps. The new estimators are a bit slower to adapt down so the maximum delay is a bit higher, especially at lower bitrates. None of the estimators work at 10 kbps, but that is likely because the bitrate controller is configured to never go below 10 kbps. This means that it's impossible to empty the queues after a capacity drop to 10kbps (regardless of what the estimators do), so the delay stays high until the capacity increases. BUG=webrtc:7022 Review-Url: https://codereview.webrtc.org/2644463009 Cr-Commit-Position: refs/heads/master@{#16233} Committed: https://chromium.googlesource.com/external/webrtc/+/568c9e72d149662dab92a671bd3139e4ae7f167a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
terelius
3 years, 11 months ago (2017-01-20 11:03:48 UTC) #6
stefan-webrtc
lgtm fyi, in the WebRTC-Audio-SendSideBwe field trial we turn down the min bwe to 6 ...
3 years, 11 months ago (2017-01-20 12:07:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2644463009/1
3 years, 11 months ago (2017-01-23 14:27:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/17907) win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-23 14:27:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2644463009/1
3 years, 11 months ago (2017-01-24 09:08:45 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 10:03:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/568c9e72d149662dab92a671b...

Powered by Google App Engine
This is Rietveld 408576698