Delete unneeded includes of base/common.h.

Delete unneeded includes of base/common.h.

Bulk of the changes were done using

   git grep -l '#include "webrtc/base/common.h"' | \
     xargs sed -i '\,^#include.*webrtc/base/common\.h,d'

followed by adding back the include in the few places where it is
still needed, and in one case (pseudotcp.cc) instead deleting its use
of RTC_UNUSED.

BUG=webrtc:6424
Review-Url: https://codereview.webrtc.org/2644103002
Cr-Commit-Position: refs/heads/master@{#16263}
Committed: https://chromium.googlesource.com/external/webrtc/+/7d2542623aa5e94a4fdb513f02f1b4e7ca2a4474

[nisse-webrtc, 2017-01-19 14:10:58]

nisse@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[nisse-webrtc, 2017-01-19 14:10:59]

This is a large but simple followup, updating the #include lines after removing
use of ASSERT().

[kwiberg-webrtc, 2017-01-23 14:59:06]

lgtm

> Bulk of the changes were done using
>
>    git grep -l '#include "webrtc/base/common.h"' | \
>      xargs sed -i '\,^#include.*webrtc/base/common\.h,d'
>
> followed by adding back the include in the few places where it is
> still needed, and in one case (pseudotcp.cc) instead deleting its
> use of RTC_UNUSED.

In the future, could you please do the automatic stuff *and nothing
else* in one patch set, and the manual fixups in a second patch set,
even if the first patch set doesn't even compile? Otherwise, the only
way for me to review the manual changes is to wade through all the
automatic changes...

[nisse-webrtc, 2017-01-23 15:51:37]

On 2017/01/23 14:59:06, kwiberg-webrtc wrote:
> lgtm
> 
> > Bulk of the changes were done using
> >
> >    git grep -l '#include "webrtc/base/common.h"' | \
> >      xargs sed -i '\,^#include.*webrtc/base/common\.h,d'
> >
> > followed by adding back the include in the few places where it is
> > still needed, and in one case (pseudotcp.cc) instead deleting its
> > use of RTC_UNUSED.
> 
> In the future, could you please do the automatic stuff *and nothing
> else* in one patch set, and the manual fixups in a second patch set,
> even if the first patch set doesn't even compile? Otherwise, the only
> way for me to review the manual changes is to wade through all the
> automatic changes...

I'll keep that in mind. Not used to uploading broken patch sets, but I 
understand it would have made reviewing this cl easier.

[kwiberg-webrtc, 2017-01-23 15:55:09]

On 2017/01/23 15:51:37, nisse-webrtc wrote:
> On 2017/01/23 14:59:06, kwiberg-webrtc wrote:
> > lgtm
> > 
> > > Bulk of the changes were done using
> > >
> > >    git grep -l '#include "webrtc/base/common.h"' | \
> > >      xargs sed -i '\,^#include.*webrtc/base/common\.h,d'
> > >
> > > followed by adding back the include in the few places where it is
> > > still needed, and in one case (pseudotcp.cc) instead deleting its
> > > use of RTC_UNUSED.
> > 
> > In the future, could you please do the automatic stuff *and nothing
> > else* in one patch set, and the manual fixups in a second patch set,
> > even if the first patch set doesn't even compile? Otherwise, the only
> > way for me to review the manual changes is to wade through all the
> > automatic changes...
> 
> I'll keep that in mind. Not used to uploading broken patch sets, but I 
> understand it would have made reviewing this cl easier.

Yes, it's a bit counterintuitive at first. But at least it's broken patch sets,
not broken CLs...

[nisse-webrtc, 2017-01-25 08:00:03]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 08:00:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-01-25 08:00:14]

The CQ bit was unchecked by nisse@webrtc.org

[nisse-webrtc, 2017-01-25 08:11:55]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 08:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 09:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 09:29:25]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-01-25 09:44:21]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-01-25 09:44:22]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2644103002/#ps60001 (title:
"Rebase.")

[commit-bot: I haz the power, 2017-01-25 09:44:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 09:47:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485337461788720,
"parent_rev": "b63a8ac5da2a45a7d0ccfec70c96eb4e949bd2fe", "commit_rev":
"7d2542623aa5e94a4fdb513f02f1b4e7ca2a4474"}

[commit-bot: I haz the power, 2017-01-25 09:47:28]

Description was changed from

==========
Delete unneeded includes of base/common.h.

Bulk of the changes were done using

   git grep -l '#include "webrtc/base/common.h"' | \
     xargs sed -i '\,^#include.*webrtc/base/common\.h,d'

followed by adding back the include in the few places where it is
still needed, and in one case (pseudotcp.cc) instead deleting its use
of RTC_UNUSED.

BUG=webrtc:6424
==========

to

==========
Delete unneeded includes of base/common.h.

Bulk of the changes were done using

   git grep -l '#include "webrtc/base/common.h"' | \
     xargs sed -i '\,^#include.*webrtc/base/common\.h,d'

followed by adding back the include in the few places where it is
still needed, and in one case (pseudotcp.cc) instead deleting its use
of RTC_UNUSED.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2644103002
Cr-Commit-Position: refs/heads/master@{#16263}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7d2542623aa5e94a4fdb513f0...
==========

[commit-bot: I haz the power, 2017-01-25 09:47:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/7d2542623aa5e94a4fdb513f0...