Add script for plotting statistics from webrtc integration test logs.

Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used to plot stats from (not yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used by plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2643853002
Cr-Commit-Position: refs/heads/master@{#16528}
Committed: https://chromium.googlesource.com/external/webrtc/+/38e9324e4e1da12ad1e8dd8451958c3b8b3f6fc4

[åsapersson, 2017-01-19 14:52:27]

Patchset #1 (id:1) has been deleted

[åsapersson, 2017-02-08 15:15:33]

Description was changed from

==========
Add script for plotting statistics from webrtc integration test logs.

BUG=webrtc:6634
==========

to

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used for plotting (not
used yet).

Move VideoProcessorIntegrationTest fixture to separate file. To be used
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

[åsapersson, 2017-02-08 15:15:44]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 15:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2017-02-08 15:16:11]

Description was changed from

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used for plotting (not
used yet).

Move VideoProcessorIntegrationTest fixture to separate file. To be used
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

to

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used for plotting (not
yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

[åsapersson, 2017-02-08 15:16:37]

Description was changed from

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used for plotting (not
yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

to

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used for plotting (not
yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used by
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

[åsapersson, 2017-02-08 15:42:10]

Patchset #3 (id:60001) has been deleted

[åsapersson, 2017-02-08 15:44:46]

Description was changed from

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used for plotting (not
yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used by
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

to

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used to plot stats from
(not yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used by
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

[åsapersson, 2017-02-08 15:44:46]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[åsapersson, 2017-02-09 11:07:31]

Patchset #5 (id:120001) has been deleted

[åsapersson, 2017-02-09 11:08:00]

Patchset #4 (id:100001) has been deleted

[åsapersson, 2017-02-09 13:00:10]

Patchset #4 (id:140001) has been deleted

[brandtr, 2017-02-09 13:32:43]

lgtm! Just some nits :)

This will be a great tool to evaluate codec settings with.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
File
webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc:39:
void SetUp() { VideoProcessorIntegrationTest::SetUp(); }
Are these two member functions needed?

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py (right):

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:91:
METRICS_TO_PARSE = []
Could this be replaced by list concatenation?

METRICS_TO_PARSE = SETTINGS + X_SETTINGS + RESULTS

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:99: Y_METRICS =
[]
And here a list comprehension?

Y_METRICS = [ res[1] for res in RESULTS ]

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:106:
FIG_SIZE_SCALE_FACTOR_X = 2
Place FIG_SIZE_SCALE_FACTOR_X before the corresponding Y? For consistency with
definitions above.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:110: def
ToString(input_list):
Move ToString and ToStringWithoutMetric closer to where they are being used,
i.e., main.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:264: pattern =
r'%s\s*[:=]\s*([+-]?\d+\.*\d*)' % name
I don't fully understand this regex. Maybe a short example could be added, that
shows a typical line matching this regex?

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:270: pattern =
r'%s\s*[:=]\s*(\w+)' % name
Same thing here.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
(right):

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:534:
void SetRateProfilePars(RateProfile* rate_profile,
Make all these member functions static, to show that they are just helper
functions?

static void SetRateProfilePars, etc.

[åsapersson, 2017-02-09 16:33:23]

Patchset #5 (id:180001) has been deleted

[åsapersson, 2017-02-09 16:39:36]

asapersson@webrtc.org changed reviewers:
+ sprang@webrtc.org

[åsapersson, 2017-02-09 16:39:37]

+sprang, can you please also have a look?

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
File
webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc:39:
void SetUp() { VideoProcessorIntegrationTest::SetUp(); }
On 2017/02/09 13:32:42, brandtr wrote:
> Are these two member functions needed?

Removed the functions.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py (right):

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:91:
METRICS_TO_PARSE = []
On 2017/02/09 13:32:42, brandtr wrote:
> Could this be replaced by list concatenation?
> 
> METRICS_TO_PARSE = SETTINGS + X_SETTINGS + RESULTS

Done.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:99: Y_METRICS =
[]
On 2017/02/09 13:32:42, brandtr wrote:
> And here a list comprehension?
> 
> Y_METRICS = [ res[1] for res in RESULTS ]

Done.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:106:
FIG_SIZE_SCALE_FACTOR_X = 2
On 2017/02/09 13:32:42, brandtr wrote:
> Place FIG_SIZE_SCALE_FACTOR_X before the corresponding Y? For consistency with
> definitions above.

Done.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:110: def
ToString(input_list):
On 2017/02/09 13:32:42, brandtr wrote:
> Move ToString and ToStringWithoutMetric closer to where they are being used,
> i.e., main.

Done.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:264: pattern =
r'%s\s*[:=]\s*([+-]?\d+\.*\d*)' % name
On 2017/02/09 13:32:42, brandtr wrote:
> I don't fully understand this regex. Maybe a short example could be added,
that
> shows a typical line matching this regex?

Done.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py:270: pattern =
r'%s\s*[:=]\s*(\w+)' % name
On 2017/02/09 13:32:42, brandtr wrote:
> Same thing here.

Done.

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h
(right):

https://codereview.webrtc.org/2643853002/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h:534:
void SetRateProfilePars(RateProfile* rate_profile,
On 2017/02/09 13:32:43, brandtr wrote:
> Make all these member functions static, to show that they are just helper
> functions?
> 
> static void SetRateProfilePars, etc.

Done.

[åsapersson, 2017-02-09 16:42:32]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 16:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sprang_webrtc, 2017-02-09 16:51:32]

I'm a complete python noob, so I'll trust your judgement there. :)
lgtm

[commit-bot: I haz the power, 2017-02-09 17:57:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 17:57:54]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-02-10 09:34:35]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-02-10 09:34:36]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2643853002/#ps200001 (title:
"address comments")

[commit-bot: I haz the power, 2017-02-10 09:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 09:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1486719275857670,
"parent_rev": "55c5be0a03bf7510fc6acada496551befb181918", "commit_rev":
"38e9324e4e1da12ad1e8dd8451958c3b8b3f6fc4"}

[commit-bot: I haz the power, 2017-02-10 09:37:20]

Description was changed from

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used to plot stats from
(not yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used by
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634
==========

to

==========
Add script for plotting statistics from webrtc integration test logs.

Add tests (plot_videoprocessor_integrationtest.cc) to be used to plot stats from
(not yet used).

Move VideoProcessorIntegrationTest fixture to separate file. To be used by
plot_videoprocessor_integrationtest.cc.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2643853002
Cr-Commit-Position: refs/heads/master@{#16528}
Committed:
https://chromium.googlesource.com/external/webrtc/+/38e9324e4e1da12ad1e8dd845...
==========

[commit-bot: I haz the power, 2017-02-10 09:37:21]

Committed patchset #5 (id:200001) as
https://chromium.googlesource.com/external/webrtc/+/38e9324e4e1da12ad1e8dd845...