Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2643763002: Revert of Add experimental simulcast screen content mode (Closed)

Created:
3 years, 11 months ago by sprang_webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add experimental simulcast screen content mode (patchset #5 id:80001 of https://codereview.webrtc.org/2636443002/ ) Reason for revert: Breaks chromium. Original issue's description: > Add experimental simulcast screen content mode > > BUG=webrtc:4172 > > Review-Url: https://codereview.webrtc.org/2636443002 > Cr-Commit-Position: refs/heads/master@{#16135} > Committed: https://chromium.googlesource.com/external/webrtc/+/a28e971e3bc8a06f366f0ef82cc7168b05a83b59 TBR=perkj@webrtc.org,asapersson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4172 Review-Url: https://codereview.webrtc.org/2643763002 Cr-Commit-Position: refs/heads/master@{#16145} Committed: https://chromium.googlesource.com/external/webrtc/+/44303ea0ffad4ddc0944361a32f9243e01e776b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -182 lines) Patch
M webrtc/media/engine/simulcast.h View 2 chunks +1 line, -6 lines 0 comments Download
M webrtc/media/engine/simulcast.cc View 10 chunks +36 lines, -65 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 5 chunks +23 lines, -27 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 7 chunks +11 lines, -65 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc View 4 chunks +5 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/video_codec_initializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sprang_webrtc
Created Revert of Add experimental simulcast screen content mode
3 years, 11 months ago (2017-01-18 13:18:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2643763002/1
3 years, 11 months ago (2017-01-18 13:19:06 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 13:19:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/44303ea0ffad4ddc0944361a3...

Powered by Google App Engine
This is Rietveld 408576698