Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2642713004: RTCMediaStreamTrackStats.framesDecoded collected. (Closed)

Created:
3 years, 11 months ago by hbos
Modified:
3 years, 11 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/api/rtcstatscollector.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
hbos
Please take a look, hta.
3 years, 11 months ago (2017-01-19 15:05:35 UTC) #4
hta-webrtc
lgtm https://codereview.webrtc.org/2642713004/diff/1/webrtc/api/rtcstatscollector_unittest.cc File webrtc/api/rtcstatscollector_unittest.cc (right): https://codereview.webrtc.org/2642713004/diff/1/webrtc/api/rtcstatscollector_unittest.cc#newcode1637 webrtc/api/rtcstatscollector_unittest.cc:1637: expected_remote_video_track_ssrc4.frames_decoded = 0; If we expect in the ...
3 years, 11 months ago (2017-01-20 09:41:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2642713004/20001
3 years, 11 months ago (2017-01-20 14:43:03 UTC) #10
hbos
https://codereview.webrtc.org/2642713004/diff/1/webrtc/api/rtcstatscollector_unittest.cc File webrtc/api/rtcstatscollector_unittest.cc (right): https://codereview.webrtc.org/2642713004/diff/1/webrtc/api/rtcstatscollector_unittest.cc#newcode1637 webrtc/api/rtcstatscollector_unittest.cc:1637: expected_remote_video_track_ssrc4.frames_decoded = 0; On 2017/01/20 09:41:36, hta-webrtc wrote: > ...
3 years, 11 months ago (2017-01-20 14:45:48 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 15:39:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f64941f1a5a18cf47152c5b93...

Powered by Google App Engine
This is Rietveld 408576698