Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2642703002: Add failure type parameter to onFailure callback. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add failure type parameter to onFailure callback. This allows Camera2Session to correctly signal camera disconnect when starting the camera. BUG=webrtc:7008 Review-Url: https://codereview.webrtc.org/2642703002 Cr-Commit-Position: refs/heads/master@{#16142} Committed: https://chromium.googlesource.com/external/webrtc/+/5850a9484d21926f8c71c7ff899f3548d55ff794

Patch Set 1 : Correctly handle failure type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M webrtc/sdk/android/api/org/webrtc/Camera1Session.java View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/Camera2Session.java View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/CameraCapturer.java View 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/CameraSession.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-18 08:52:08 UTC) #4
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-18 10:03:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2642703002/20001
3 years, 11 months ago (2017-01-18 10:04:36 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 11:22:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5850a9484d21926f8c71c7ff8...

Powered by Google App Engine
This is Rietveld 408576698