Issue 2641233002: Enable -Wno-unused-lambda-capture warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2641233002: Enable -Wno-unused-lambda-capture warning (Closed)

Created:
3 years, 11 months ago by kjellander_webrtc

Modified:
3 years, 11 months ago

Reviewers:
the sun

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Enable -Wno-unused-lambda-capture warning To prevent future regressions for this warning (one was recently fixed in https://codereview.webrtc.org/2639523002) BUG=none TBR=solenberg@webrtc.org

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webrtc/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kjellander_webrtc

Nevermind, this can only be enabled for head LLVM, so I'm closing this CL waiting ...

3 years, 11 months ago (2017-01-19 19:46:17 UTC) #1

the sun

3 years, 11 months ago (2017-01-19 22:11:45 UTC) #3

Message was sent while issue was closed.

On 2017/01/19 19:46:17, kjellander_webrtc wrote:
> Nevermind, this can only be enabled for head LLVM, so I'm closing this CL
> waiting for that to happen. It's probably not worth setting up Clang ToT
> builders for WebRTC only for this unless we find other breakages.

Good call. It was an easy fix anyhow.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages