Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2639523002: Remove unused lambda capture to unbreak downstream code. (Closed)

Created:
3 years, 11 months ago by the sun
Modified:
3 years, 11 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
the sun
3 years, 11 months ago (2017-01-17 11:01:48 UTC) #2
perkj_webrtc
lgtm but please tbr an author/owner of this class.
3 years, 11 months ago (2017-01-17 11:21:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639523002/1
3 years, 11 months ago (2017-01-17 11:45:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16777)
3 years, 11 months ago (2017-01-17 12:55:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639523002/1
3 years, 11 months ago (2017-01-17 13:12:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/e08b253ee0313f09d8fd85231402e01aca2d9ee1
3 years, 11 months ago (2017-01-17 14:18:16 UTC) #14
kjellander_webrtc
3 years, 11 months ago (2017-01-19 19:34:46 UTC) #15
Message was sent while issue was closed.
On 2017/01/17 14:18:16, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/e08b253ee0313f09d8fd85231...

I'm enabling the warning for our code so we don't regress in the future in
https://codereview.webrtc.org/2641233002/

Powered by Google App Engine
This is Rietveld 408576698