Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2641203002: GN: Add audio_conference_mixer_unittests to modules_unittests. (Closed)

Created:
3 years, 11 months ago by ehmaldonado_webrtc
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add audio_conference_mixer_unittests to modules_unittests. Was removed by accident in https://codereview.webrtc.org/2629923002/ BUG=webrtc:6954 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2641203002 Cr-Commit-Position: refs/heads/master@{#16170} Committed: https://chromium.googlesource.com/external/webrtc/+/9410b51037ab6b2497b03f3888a3e1defd9dcbeb

Patch Set 1 #

Patch Set 2 : Windows flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ehmaldonado_webrtc
Sorry, I forgot. And of course there was a bug...
3 years, 11 months ago (2017-01-19 18:28:51 UTC) #1
kjellander_webrtc
lgtm, that's why we have code reviews :)
3 years, 11 months ago (2017-01-19 19:25:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2641203002/20001
3 years, 11 months ago (2017-01-19 19:55:02 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 19:58:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/9410b51037ab6b2497b03f388...

Powered by Google App Engine
This is Rietveld 408576698