Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2641133002: Reland of Add experimental simulcast screen content mode (Closed)

Created:
3 years, 11 months ago by sprang_webrtc
Modified:
3 years, 10 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman, åsapersson, perkj_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add experimental simulcast screen content mode The original CL was reverted because of a bug discovered by the chromium bots. Description of that CL: > Review-Url: https://codereview.webrtc.org/2636443002 > Cr-Commit-Position: refs/heads/master@{#16135} > Committed: https://chromium.googlesource.com/external/webrtc/+/a28e971e3bc8a06f366f0ef82cc7168b05a83b59 The first patch set of this CL is the same as r16135. Subsequence patch sets are the fixes applied. Some new test cases have been added, which reveal a few more bugs that have also been fixed. BUG=webrtc:4172 Review-Url: https://codereview.webrtc.org/2641133002 Cr-Commit-Position: refs/heads/master@{#16299} Committed: https://chromium.googlesource.com/external/webrtc/+/429600d7d00b526b3b35b6387b7d72a053709860

Patch Set 1 #

Patch Set 2 : Fixed bug, extended test coverage #

Patch Set 3 : Rebase error #

Patch Set 4 : Missing file #

Total comments: 3

Patch Set 5 : Rebase #

Patch Set 6 : Fixed memory leak in unit test #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -94 lines) Patch
M webrtc/media/engine/simulcast.h View 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/media/engine/simulcast.cc View 1 2 3 4 5 6 10 chunks +64 lines, -35 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 2 3 4 5 chunks +27 lines, -23 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 2 3 4 7 chunks +64 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/utility/simulcast_rate_allocator.cc View 1 1 chunk +12 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/video_codec_initializer.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download
A webrtc/modules/video_coding/video_codec_initializer_unittest.cc View 1 2 3 4 5 1 chunk +217 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (26 generated)
sprang_webrtc
3 years, 11 months ago (2017-01-19 12:00:08 UTC) #8
sprang_webrtc
asapersson@ is ooo +magjed, can you take a look as you're an owner of webrtc/media? ...
3 years, 11 months ago (2017-01-23 09:41:56 UTC) #12
magjed_webrtc
https://codereview.webrtc.org/2641133002/diff/60001/webrtc/media/engine/webrtcvideoengine2.cc File webrtc/media/engine/webrtcvideoengine2.cc (right): https://codereview.webrtc.org/2641133002/diff/60001/webrtc/media/engine/webrtcvideoengine2.cc#newcode1679 webrtc/media/engine/webrtcvideoengine2.cc:1679: WebRtcSimulcastEncoderFactory adapter_factory( Do we really need to have a ...
3 years, 11 months ago (2017-01-23 10:36:24 UTC) #13
sprang_webrtc
https://codereview.webrtc.org/2641133002/diff/60001/webrtc/media/engine/webrtcvideoengine2.cc File webrtc/media/engine/webrtcvideoengine2.cc (right): https://codereview.webrtc.org/2641133002/diff/60001/webrtc/media/engine/webrtcvideoengine2.cc#newcode1679 webrtc/media/engine/webrtcvideoengine2.cc:1679: WebRtcSimulcastEncoderFactory adapter_factory( On 2017/01/23 10:36:24, magjed_webrtc wrote: > Do ...
3 years, 11 months ago (2017-01-23 12:09:32 UTC) #14
sprang_webrtc
ping?
3 years, 11 months ago (2017-01-24 09:55:06 UTC) #15
magjed_webrtc
lgtm https://codereview.webrtc.org/2641133002/diff/60001/webrtc/media/engine/webrtcvideoengine2.cc File webrtc/media/engine/webrtcvideoengine2.cc (right): https://codereview.webrtc.org/2641133002/diff/60001/webrtc/media/engine/webrtcvideoengine2.cc#newcode1679 webrtc/media/engine/webrtcvideoengine2.cc:1679: WebRtcSimulcastEncoderFactory adapter_factory( On 2017/01/23 12:09:32, språng wrote: > ...
3 years, 11 months ago (2017-01-24 09:58:52 UTC) #16
sprang_webrtc
On 2017/01/24 09:58:52, magjed_webrtc wrote: > lgtm > > https://codereview.webrtc.org/2641133002/diff/60001/webrtc/media/engine/webrtcvideoengine2.cc > File webrtc/media/engine/webrtcvideoengine2.cc (right): > ...
3 years, 10 months ago (2017-01-24 13:06:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2641133002/60001
3 years, 10 months ago (2017-01-24 13:06:19 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/21349)
3 years, 10 months ago (2017-01-24 13:08:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2641133002/80001
3 years, 10 months ago (2017-01-24 13:43:49 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_memcheck on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/4460)
3 years, 10 months ago (2017-01-24 14:17:51 UTC) #26
sprang_webrtc
Fixed a memory leak in the unit test, do you wanna have a look or ...
3 years, 10 months ago (2017-01-25 15:08:13 UTC) #31
magjed_webrtc
On 2017/01/25 15:08:13, språng wrote: > Fixed a memory leak in the unit test, do ...
3 years, 10 months ago (2017-01-25 18:59:59 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2641133002/100001
3 years, 10 months ago (2017-01-26 07:44:58 UTC) #35
commit-bot: I haz the power
Failed to apply patch for webrtc/media/engine/simulcast.cc: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-01-26 08:35:04 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2641133002/120001
3 years, 10 months ago (2017-01-26 13:12:21 UTC) #40
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 14:12:35 UTC) #43
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/429600d7d00b526b3b35b6387...

Powered by Google App Engine
This is Rietveld 408576698