Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2640543003: Increase bitrate adjustment values for VP8 Exynos encoder (Closed)

Created:
3 years, 11 months ago by AlexG
Modified:
3 years, 11 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, magjed_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase bitrate adjustment values for VP8 Exynos encoder For low bitrates actual encoder output bitrate may differ from target by 3-4 times. Also adjust adaptation speed based on bitrate variation from the target. BUG=b/34233384 R=wzh@webrtc.org Review-Url: https://codereview.webrtc.org/2640543003 . Cr-Commit-Position: refs/heads/master@{#16128} Committed: https://chromium.googlesource.com/external/webrtc/+/7fa4a729245a401209310400e7a4df4e416e96a2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
AlexG
PTAL
3 years, 11 months ago (2017-01-17 22:50:21 UTC) #2
wzh
lgtm https://codereview.webrtc.org/2640543003/diff/1/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/2640543003/diff/1/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java#newcode756 webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:756: int bitrateAdjustmentInc = (int) (bitrateAccumulator / bitrateAccumulatorMax + ...
3 years, 11 months ago (2017-01-17 22:54:19 UTC) #3
AlexG
On 2017/01/17 22:54:19, wzh wrote: > lgtm > > https://codereview.webrtc.org/2640543003/diff/1/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java > File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right): > ...
3 years, 11 months ago (2017-01-17 23:08:34 UTC) #4
AlexG
3 years, 11 months ago (2017-01-17 23:08:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2640543003/20001
3 years, 11 months ago (2017-01-17 23:09:04 UTC) #8
AlexG
3 years, 11 months ago (2017-01-17 23:32:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7fa4a729245a401209310400e7a4df4e416e96a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698