Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2640433003: Android: AppRTCMobile: Don't leak CallActivity. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: AppRTCMobile: Don't leak CallActivity. Previously CallActivity would be leaked on every call. This CL fixes the problem. BUG=webrtc:6684 Review-Url: https://codereview.webrtc.org/2640433003 Cr-Commit-Position: refs/heads/master@{#16123} Committed: https://chromium.googlesource.com/external/webrtc/+/e5cbc2019003dbb40e03811d7607feb95757a4ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 5 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-17 13:30:32 UTC) #3
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-17 14:20:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2640433003/1
3 years, 11 months ago (2017-01-17 14:22:16 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 15:25:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e5cbc2019003dbb40e03811d7...

Powered by Google App Engine
This is Rietveld 408576698