Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2640263002: Add metric for decode time and max decode time in video quality tests. (Closed)

Created:
3 years, 11 months ago by philipel
Modified:
3 years, 11 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add metric for decode time and max decode time in video quality tests. BUG=chromium:672007 Review-Url: https://codereview.webrtc.org/2640263002 Cr-Commit-Position: refs/heads/master@{#16208} Committed: https://chromium.googlesource.com/external/webrtc/+/fd870db0b216d73cda991715f94b95b3e7e29244

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -16 lines) Patch
M webrtc/video/video_quality_test.cc View 7 chunks +41 lines, -16 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
philipel
3 years, 11 months ago (2017-01-19 11:35:34 UTC) #2
sprang_webrtc
https://codereview.webrtc.org/2640263002/diff/1/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2640263002/diff/1/webrtc/video/video_quality_test.cc#newcode542 webrtc/video/video_quality_test.cc:542: rtc::CritScope crit(&comparison_lock_); Why move the lock to include getting ...
3 years, 11 months ago (2017-01-19 12:09:30 UTC) #3
philipel
https://codereview.webrtc.org/2640263002/diff/1/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2640263002/diff/1/webrtc/video/video_quality_test.cc#newcode542 webrtc/video/video_quality_test.cc:542: rtc::CritScope crit(&comparison_lock_); On 2017/01/19 12:09:30, språng wrote: > Why ...
3 years, 11 months ago (2017-01-19 15:11:39 UTC) #4
sprang_webrtc
lgtm
3 years, 11 months ago (2017-01-23 10:05:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2640263002/1
3 years, 11 months ago (2017-01-23 10:27:10 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 11:22:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fd870db0b216d73cda991715f...

Powered by Google App Engine
This is Rietveld 408576698