Camera1Session: Fix camera sometimes getting stopped twice.

Camera1Session: Fix camera sometimes getting stopped twice.

Moves setting state as stopped to stopInternal. Checks that state is not
stopped in stopInternal.

BUG=webrtc:7015
Review-Url: https://codereview.webrtc.org/2640093003
Cr-Commit-Position: refs/heads/master@{#16182}
Committed: https://chromium.googlesource.com/external/webrtc/+/35564065ca6d5d2513fb89af6e048e07cf57b003

[sakal, 2017-01-19 10:33:40]

Description was changed from

==========
Fix camera sometimes getting stopped twice.

BUG=
==========

to

==========
Camera1Session: Fix camera sometimes getting stopped twice.

BUG=webrtc:7015
==========

[sakal, 2017-01-19 10:33:40]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2017-01-19 10:35:44]

Description was changed from

==========
Camera1Session: Fix camera sometimes getting stopped twice.

BUG=webrtc:7015
==========

to

==========
Camera1Session: Fix camera sometimes getting stopped twice.

Moves setting state as stopped to stopInternal. Checks that state is not
stopped in stopInternal.

BUG=webrtc:7015
==========

[sakal, 2017-01-19 10:36:12]

PTAL

[magjed_webrtc, 2017-01-20 09:38:47]

lgtm % nit

https://codereview.webrtc.org/2640093003/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/Camera1Session.java (right):

https://codereview.webrtc.org/2640093003/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/Camera1Session.java:228: if (state !=
SessionState.STOPPED) {
nit: I would prefer if you switched this if-statement around and did:
if (state == SessionState.STOPPED) {
  Logging.d(TAG, "Camera is already stopped");
  return;
}
state = SessionState.STOPPED;
surfaceTextureHelper.stopListening();
...

[sakal, 2017-01-20 09:46:17]

Patchset #2 (id:20001) has been deleted

[sakal, 2017-01-20 09:47:16]

https://codereview.webrtc.org/2640093003/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/Camera1Session.java (right):

https://codereview.webrtc.org/2640093003/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/Camera1Session.java:228: if (state !=
SessionState.STOPPED) {
On 2017/01/20 09:38:46, magjed_webrtc wrote:
> nit: I would prefer if you switched this if-statement around and did:
> if (state == SessionState.STOPPED) {
>   Logging.d(TAG, "Camera is already stopped");
>   return;
> }
> state = SessionState.STOPPED;
> surfaceTextureHelper.stopListening();
> ...

Done.

[sakal, 2017-01-20 09:47:19]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2017-01-20 09:47:19]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2640093003/#ps40001 (title:
"Switch if-statement around")

[commit-bot: I haz the power, 2017-01-20 09:47:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-20 11:09:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484905639224870,
"parent_rev": "9e30274c03c8e812abeb37c7876648e3cae0805a", "commit_rev":
"35564065ca6d5d2513fb89af6e048e07cf57b003"}

[commit-bot: I haz the power, 2017-01-20 11:09:06]

Description was changed from

==========
Camera1Session: Fix camera sometimes getting stopped twice.

Moves setting state as stopped to stopInternal. Checks that state is not
stopped in stopInternal.

BUG=webrtc:7015
==========

to

==========
Camera1Session: Fix camera sometimes getting stopped twice.

Moves setting state as stopped to stopInternal. Checks that state is not
stopped in stopInternal.

BUG=webrtc:7015

Review-Url: https://codereview.webrtc.org/2640093003
Cr-Commit-Position: refs/heads/master@{#16182}
Committed:
https://chromium.googlesource.com/external/webrtc/+/35564065ca6d5d2513fb89af6...
==========

[commit-bot: I haz the power, 2017-01-20 11:09:07]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/35564065ca6d5d2513fb89af6...