Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2639423007: Drop pacer and retransmission_rate_limiter from RtpStreamReceiver constructor. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 11 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop pacer and retransmission_rate_limiter from RtpStreamReceiver constructor. They were passed on via RtpRtcp::Configuration, but unused for a receive only RtpRtcp module. BUG=webrtc:6847 Review-Url: https://codereview.webrtc.org/2639423007 Cr-Commit-Position: refs/heads/master@{#16234} Committed: https://chromium.googlesource.com/external/webrtc/+/15389c034d45eeaa81b4390a4959ddbc18e47540

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M webrtc/video/rtp_stream_receiver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 5 chunks +2 lines, -10 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
nisse-webrtc
PTAL. I'm trying to limit the amount of CongestionController related objects which are passed down ...
3 years, 11 months ago (2017-01-20 14:42:35 UTC) #2
sprang_webrtc
lgtm, but please double check that we won't break any downstream projects
3 years, 11 months ago (2017-01-23 13:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639423007/20001
3 years, 11 months ago (2017-01-24 10:21:27 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 10:37:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/15389c034d45eeaa81b4390a4...

Powered by Google App Engine
This is Rietveld 408576698