Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2639423006: Clear out cached codecs when calculating new codec lists. (Closed)

Created:
3 years, 11 months ago by noahric
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clear out cached codecs when calculating new codec lists. Without this, every time WebRtcVideoEngine2 calls supported_codecs(), the codec list grows. BUG=webrtc:7020 Review-Url: https://codereview.webrtc.org/2639423006 Cr-Commit-Position: refs/heads/master@{#16178} Committed: https://chromium.googlesource.com/external/webrtc/+/be850e1b1de5bf046080ac1df7de67a3d6d12d1c

Patch Set 1 #

Patch Set 2 : Format cl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoencoderfactory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A webrtc/media/engine/webrtcvideoencoderfactory_unittest.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
noahric
3 years, 11 months ago (2017-01-20 01:56:28 UTC) #3
magjed_webrtc
lgtm Thanks for fixing this. lgtm
3 years, 11 months ago (2017-01-20 09:04:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639423006/20001
3 years, 11 months ago (2017-01-20 09:05:11 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 09:07:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/be850e1b1de5bf046080ac1df...

Powered by Google App Engine
This is Rietveld 408576698