Use std::unique_ptr in VideoProcessorIntegrationTest.

Use std::unique_ptr in VideoProcessorIntegrationTest.

Add more logging of codec settings.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2639203005
Cr-Commit-Position: refs/heads/master@{#16464}
Committed: https://chromium.googlesource.com/external/webrtc/+/e0ac5a6c15899830a95828c87823357fd27e3d84

[åsapersson, 2017-02-06 14:37:39]

Description was changed from

==========
Use std::unique_ptr in VideoProcessorIntegrationTest.

BUG=webrtc:6634
==========

to

==========
Use std::unique_ptr in VideoProcessorIntegrationTest.

Add more logging of codec settings.

BUG=webrtc:6634
==========

[åsapersson, 2017-02-06 14:47:54]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 14:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2017-02-06 15:40:15]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[commit-bot: I haz the power, 2017-02-06 16:00:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:00:37]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-02-07 08:25:53]

lgtm

https://codereview.webrtc.org/2639203005/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/2639203005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:522:
void SetRateProfilePars(RateProfile* rate_profile,
Make these four functions static?

[åsapersson, 2017-02-07 08:44:10]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 08:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2017-02-07 08:57:05]

asapersson@webrtc.org changed reviewers:
+ sprang@webrtc.org

[åsapersson, 2017-02-07 08:57:05]

+sprang

https://codereview.webrtc.org/2639203005/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/2639203005/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:522:
void SetRateProfilePars(RateProfile* rate_profile,
On 2017/02/07 08:25:53, brandtr wrote:
> Make these four functions static?

Done.

[sprang_webrtc, 2017-02-07 09:18:37]

https://codereview.webrtc.org/2639203005/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right):

https://codereview.webrtc.org/2639203005/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:42: }
Maybe use CodecTypeToPayloadName() from webrtc/common_types.h instead?

[commit-bot: I haz the power, 2017-02-07 09:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 09:35:02]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-02-07 09:39:34]

https://codereview.webrtc.org/2639203005/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right):

https://codereview.webrtc.org/2639203005/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:42: }
On 2017/02/07 09:18:36, språng wrote:
> Maybe use CodecTypeToPayloadName() from webrtc/common_types.h instead?

Done.

[sprang_webrtc, 2017-02-07 09:42:58]

lgtm

[åsapersson, 2017-02-07 09:43:12]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 09:43:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 10:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 10:50:01]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-02-07 10:55:07]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-02-07 10:55:07]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2639203005/#ps60001 (title:
"use CodecTypeToPayloadName")

[commit-bot: I haz the power, 2017-02-07 10:55:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 10:57:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 10:57:27]

Failed to apply patch for
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:
While running git apply --index -p1;
  error: patch failed:
webrtc/modules/video_coding/codecs/test/videoprocessor.cc:19
  error: webrtc/modules/video_coding/codecs/test/videoprocessor.cc: patch does
not apply

Patch:       webrtc/modules/video_coding/codecs/test/videoprocessor.cc
Index: webrtc/modules/video_coding/codecs/test/videoprocessor.cc
diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
b/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
index
63f0a871503cf700bcf09f7d06425de09215c0d5..6877cad7c8ef0efc894720c02cd87e468b7caa04
100644
--- a/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
@@ -19,6 +19,7 @@
 
 #include "webrtc/base/checks.h"
 #include "webrtc/base/timeutils.h"
+#include "webrtc/common_types.h"
 #include "webrtc/modules/video_coding/include/video_codec_initializer.h"
 #include
"webrtc/modules/video_coding/utility/default_video_bitrate_allocator.h"
 #include "webrtc/modules/video_coding/utility/simulcast_rate_allocator.h"
@@ -146,10 +147,30 @@ bool VideoProcessorImpl::Init() {
     printf("  #CPU cores used  : %d\n", nbr_of_cores);
     printf("  Total # of frames: %d\n", frame_reader_->NumberOfFrames());
     printf("  Codec settings:\n");
-    printf("    Start bitrate  : %d kbps\n",
+    printf("    Start bitrate    : %d kbps\n",
            config_.codec_settings->startBitrate);
-    printf("    Width          : %d\n", config_.codec_settings->width);
-    printf("    Height         : %d\n", config_.codec_settings->height);
+    printf("    Width            : %d\n", config_.codec_settings->width);
+    printf("    Height           : %d\n", config_.codec_settings->height);
+    printf("    Codec type       : %s\n",
+           CodecTypeToPayloadName(config_.codec_settings->codecType)
+               .value_or("Unknown"));
+    printf("    Encoder implementation name: %s\n",
+           encoder_->ImplementationName());
+    printf("    Decoder implementation name: %s\n",
+           decoder_->ImplementationName());
+    if (config_.codec_settings->codecType == kVideoCodecVP8) {
+      printf("    Denoising        : %d\n",
+             config_.codec_settings->VP8()->denoisingOn);
+      printf("    Error concealment: %d\n",
+             config_.codec_settings->VP8()->errorConcealmentOn);
+      printf("    Frame dropping   : %d\n",
+             config_.codec_settings->VP8()->frameDroppingOn);
+      printf("    Resilience       : %d\n",
+             config_.codec_settings->VP8()->resilience);
+    } else if (config_.codec_settings->codecType == kVideoCodecVP9) {
+      printf("    Resilience       : %d\n",
+             config_.codec_settings->VP9()->resilience);
+    }
   }
   initialized_ = true;
   return true;

[åsapersson, 2017-02-07 11:07:32]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 11:07:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 11:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 11:50:02]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-02-07 11:51:41]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-02-07 11:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org,
sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2639203005/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2017-02-07 11:51:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 11:54:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486468301414270,
"parent_rev": "1b21b9bbf8e9d3911dba39ab09ee3d3398975c49", "commit_rev":
"e0ac5a6c15899830a95828c87823357fd27e3d84"}

[commit-bot: I haz the power, 2017-02-07 11:54:08]

Description was changed from

==========
Use std::unique_ptr in VideoProcessorIntegrationTest.

Add more logging of codec settings.

BUG=webrtc:6634
==========

to

==========
Use std::unique_ptr in VideoProcessorIntegrationTest.

Add more logging of codec settings.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2639203005
Cr-Commit-Position: refs/heads/master@{#16464}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e0ac5a6c15899830a95828c87...
==========

[commit-bot: I haz the power, 2017-02-07 11:54:09]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/e0ac5a6c15899830a95828c87...