Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2639203004: Revert of make the DtlsTransportWrapper inherit form DtlsTransportInternal (Closed)

Created:
3 years, 11 months ago by Zhi Huang
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of make the DtlsTransportWrapper inherit form DtlsTransportInternal (patchset #11 id:320001 of https://codereview.webrtc.org/2606123002/ ) Reason for revert: Failed the memory check. May need to fix the memory leak. Original issue's description: > make the DtlsTransportWrapper inherit form DtlsTransportInternal > > BUG=none > > Review-Url: https://codereview.webrtc.org/2606123002 > Cr-Commit-Position: refs/heads/master@{#16160} > Committed: https://chromium.googlesource.com/external/webrtc/+/5aed06c8d3e0bf69f06f54ee7113f7a3ac2399c7 TBR=deadbeef@webrtc.org,pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.webrtc.org/2639203004 Cr-Commit-Position: refs/heads/master@{#16162} Committed: https://chromium.googlesource.com/external/webrtc/+/6ce9259cb0bf875f444c2ea2992aa80a870c62c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1269 lines, -1009 lines) Patch
M webrtc/api/rtpsenderreceiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 9 chunks +55 lines, -55 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M webrtc/media/sctp/sctptransport.h View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/sctp/sctptransport.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/media/sctp/sctptransport_unittest.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M webrtc/media/sctp/sctptransportinternal.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 9 chunks +101 lines, -86 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 25 chunks +160 lines, -118 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 20 chunks +77 lines, -79 lines 0 comments Download
M webrtc/p2p/base/dtlstransportinternal.h View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 10 chunks +159 lines, -143 lines 0 comments Download
M webrtc/p2p/base/icetransportinternal.h View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/p2p/base/jseptransport.h View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/p2p/base/jseptransport.cc View 4 chunks +20 lines, -23 lines 0 comments Download
M webrtc/p2p/base/jseptransport_unittest.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M webrtc/p2p/base/packettransportinterface.h View 2 chunks +1 line, -3 lines 0 comments Download
A webrtc/p2p/base/transportchannel.h View 1 chunk +163 lines, -0 lines 0 comments Download
A webrtc/p2p/base/transportchannel.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 4 chunks +15 lines, -15 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 18 chunks +54 lines, -58 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 33 chunks +78 lines, -80 lines 0 comments Download
M webrtc/p2p/base/udptransport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channel.h View 13 chunks +27 lines, -32 lines 0 comments Download
M webrtc/pc/channel.cc View 35 chunks +143 lines, -155 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 19 chunks +59 lines, -63 lines 0 comments Download
M webrtc/pc/channelmanager.h View 6 chunks +12 lines, -12 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Zhi Huang
Created Revert of make the DtlsTransportWrapper inherit form DtlsTransportInternal
3 years, 11 months ago (2017-01-19 10:33:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639203004/1
3 years, 11 months ago (2017-01-19 10:33:45 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-19 10:33:47 UTC) #5
the sun
lgtm
3 years, 11 months ago (2017-01-19 12:40:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639203004/1
3 years, 11 months ago (2017-01-19 12:49:37 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 12:49:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6ce9259cb0bf875f444c2ea29...

Powered by Google App Engine
This is Rietveld 408576698