Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2639183002: Ignore ufrag/password in "a=candidate" lines in SDP. (Closed)

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignore ufrag/password in "a=candidate" lines in SDP. These attributes should be parsed in candidate trickling, but when parsing a full session description, only "a=ice-ufrag"/"a=ice-pwd" should be used to communicate the ufrag/password. BUG=chromium:681286 Review-Url: https://codereview.webrtc.org/2639183002 Cr-Commit-Position: refs/heads/master@{#16194} Committed: https://chromium.googlesource.com/external/webrtc/+/7bcdb6995777b282564359df4328328d1a58f78e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M webrtc/api/webrtcsdp.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/api/webrtcsdp_unittest.cc View 3 chunks +32 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pthatcher1
3 years, 11 months ago (2017-01-20 19:29:54 UTC) #2
pthatcher1
lgtm
3 years, 11 months ago (2017-01-20 19:29:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639183002/1
3 years, 11 months ago (2017-01-20 19:40:21 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 20:44:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7bcdb6995777b282564359df4...

Powered by Google App Engine
This is Rietveld 408576698