webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc - Issue 2638083002: Attach TransportFeedbackPacketLossTracker to ANA (PLR only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

Issue 2638083002: Attach TransportFeedbackPacketLossTracker to ANA (PLR only) (Closed)

Patch Set: Fix UT Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/congestion_controller_unittest.cc ('K') | « webrtc/modules/rtp_rtcp/source/rtp_sender.cc ('k') | webrtc/test/fuzzers/transport_feedback_packet_loss_tracker_fuzzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

index fed52ee19065f2c13c1bb0e64d052b7373548fa7..6539f736dc3e7ef13d02376b185d87f21f80c213 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

@@ -126,7 +126,8 @@ class MockSendPacketObserver : public SendPacketObserver {

class MockTransportFeedbackObserver : public TransportFeedbackObserver {

public:

- MOCK_METHOD3(AddPacket, void(uint16_t, size_t, const PacedPacketInfo&));

+ MOCK_METHOD4(AddPacket,

+ void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));

MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));

MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());

};

@@ -355,7 +356,7 @@ TEST_F(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {

.Times(1);

EXPECT_CALL(

feedback_observer_,

- AddPacket(kTransportSequenceNumber,

+ AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,

sizeof(kPayloadData) + kGenericHeaderLength, PacedPacketInfo()))

.Times(1);

@@ -406,7 +407,7 @@ TEST_F(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {

.Times(1);

EXPECT_CALL(

feedback_observer_,

- AddPacket(kTransportSequenceNumber,

+ AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,

sizeof(kPayloadData) + kGenericHeaderLength, PacedPacketInfo()))

.Times(1);

@@ -1487,7 +1488,7 @@ TEST_F(RtpSenderTest, AddOverheadToTransportFeedbackObserver) {

EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())

.WillOnce(testing::Return(kTransportSequenceNumber));

EXPECT_CALL(feedback_observer_,

- AddPacket(kTransportSequenceNumber,

+ AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,

sizeof(kPayloadData) + kGenericHeaderLength +

kRtpOverheadBytesPerPacket,

PacedPacketInfo()))