webrtc/modules/congestion_controller/congestion_controller_unittest.cc - Issue 2638083002: Attach TransportFeedbackPacketLossTracker to ANA (PLR only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/congestion_controller_unittest.cc

Issue 2638083002: Attach TransportFeedbackPacketLossTracker to ANA (PLR only) (Closed)

Patch Set: Fix UT Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/congestion_controller/congestion_controller.cc ('k') | webrtc/modules/congestion_controller/include/congestion_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/congestion_controller_unittest.cc

diff --git a/webrtc/modules/congestion_controller/congestion_controller_unittest.cc b/webrtc/modules/congestion_controller/congestion_controller_unittest.cc

index 8073ae1557b447b5215df0359ce8737d58335b95..56219363fdf70c06e1abe54267fcb569537e31da 100644

--- a/webrtc/modules/congestion_controller/congestion_controller_unittest.cc

+++ b/webrtc/modules/congestion_controller/congestion_controller_unittest.cc

@@ -79,7 +79,8 @@ class CongestionControllerTest : public ::testing::Test {

}

void OnSentPacket(const PacketFeedback& packet_feedback) {

- controller_->AddPacket(packet_feedback.sequence_number,

+ constexpr uint32_t ssrc = 0;

stefan-webrtc 2017/03/23 17:55:06 I think it would make sense to have a unittest whi

elad.alon_webrtc.org 2017/03/23 18:04:24 We don't store this, but rather make sure that we

+ controller_->AddPacket(ssrc, packet_feedback.sequence_number,

packet_feedback.payload_size,

packet_feedback.pacing_info);

controller_->OnSentPacket(rtc::SentPacket(packet_feedback.sequence_number,