webrtc/modules/rtp_rtcp/source/rtp_sender.cc - Issue 2638083002: Attach TransportFeedbackPacketLossTracker to ANA (PLR only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2638083002: Attach TransportFeedbackPacketLossTracker to ANA (PLR only) (Closed)

Patch Set: TODO replaced by task (7173). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc

index add7c21e9be22e109c15227de2b7ee0ac4336c7f..925af5f4f707b10de9d4ae3a1ac283f906ed6878 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc

@@ -1264,7 +1264,12 @@ void RTPSender::AddPacketToTransportFeedback(uint16_t packet_id,

}

if (transport_feedback_observer_) {

- transport_feedback_observer_->AddPacket(packet_id, packet_size,

+ uint32_t ssrc;

+ {

+ rtc::CritScope lock(&send_critsect_);

+ ssrc = ssrc_;

+ }

+ transport_feedback_observer_->AddPacket(ssrc, packet_id, packet_size,

probe_cluster_id);

}