Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 2638083002: Attach TransportFeedbackPacketLossTracker to ANA (PLR only) (Closed)
Patch Set: TODO replaced by task (7173). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
index 567fa0bc25539590d5a6b23c9a2d745b226f86be..b147125e567c8a0db663a0d948ad7da9e27cb93b 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
@@ -304,7 +304,8 @@ class TransportFeedbackObserver {
// Note: Transport-wide sequence number as sequence number. Arrival time
// must be set to 0.
- virtual void AddPacket(uint16_t sequence_number,
+ virtual void AddPacket(uint32_t ssrc,
+ uint16_t sequence_number,
size_t length,
int probe_cluster_id) = 0;
@@ -313,6 +314,16 @@ class TransportFeedbackObserver {
virtual std::vector<PacketInfo> GetTransportFeedbackVector() const = 0;
};
+class TransportFeedbackAdapterObserver {
minyue-webrtc 2017/02/22 11:47:55 Why cannot this be a TransportFeedbackObserver? Se
elad.alon_webrtc.org 2017/03/10 12:03:26 (For posterity - some offline discussions were mad
+ public:
+ TransportFeedbackAdapterObserver() = default;
minyue-webrtc 2017/02/22 11:47:55 no ctor needed
elad.alon_webrtc.org 2017/03/10 12:03:26 Done.
+ virtual ~TransportFeedbackAdapterObserver() = default;
+
+ virtual void OnPacketAdded(uint32_t ssrc,
+ uint16_t transport_sequence_number) = 0;
+ virtual void OnTransportFeedback(const rtcp::TransportFeedback& feedback) = 0;
+};
+
class RtcpRttStats {
public:
virtual void OnRttUpdate(int64_t rtt) = 0;

Powered by Google App Engine
This is Rietveld 408576698