Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2635893002: Fix for bwe with overhead on audio only calls. (Closed)

Created:
3 years, 11 months ago by michaelt
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix for bwe with overhead on audio only calls. BUG=webrtc:6989 Review-Url: https://codereview.webrtc.org/2635893002 Cr-Commit-Position: refs/heads/master@{#16104} Committed: https://chromium.googlesource.com/external/webrtc/+/f4caaab5189d6040039a61a2741ec4d92a62e75b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/audio/audio_send_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
michaelt
Hi i found a bug in BWE with overhead. Here the fix for it.
3 years, 11 months ago (2017-01-16 10:19:28 UTC) #3
minyue-webrtc
lgtm
3 years, 11 months ago (2017-01-16 15:26:33 UTC) #4
stefan-webrtc
lgtm, but please follow up with a test for audio + bwe + overhead compensation.
3 years, 11 months ago (2017-01-16 15:43:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2635893002/1
3 years, 11 months ago (2017-01-16 16:48:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16745)
3 years, 11 months ago (2017-01-16 17:47:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2635893002/1
3 years, 11 months ago (2017-01-16 18:01:26 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 07:55:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f4caaab5189d6040039a61a27...

Powered by Google App Engine
This is Rietveld 408576698