Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2635233002:
Load library dependencies in AppRTCMobile. (Closed)
|
Created:
3 years, 11 months ago by sakal Modified:
3 years, 11 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionLoad library dependencies in AppRTCMobile.
Older Android versions have trouble locating the library dependencies
automatically. Loading them manually resolves the issue.
BUG=webrtc:6751
Review-Url: https://codereview.webrtc.org/2635233002
Cr-Commit-Position: refs/heads/master@{#16179}
Committed: https://chromium.googlesource.com/external/webrtc/+/3e9229045ee807dcf141168a780f59ffe067c80b
Patch Set 1 #Patch Set 2 : Remove libraries from PeerConnection, add all to PeerConnectionFactory. #Patch Set 3 : Undo loadLibrary removal from PeerConnection.java #Patch Set 4 : Load libraries in PeerConnectionFactory.initializeAndroidGlobals. #Patch Set 5 : Move c++_shared to CallActivity. #Patch Set 6 : Load all dependencies in CallActivity. #Patch Set 7 : Undo changes in PeerConnection.java. #Messages
Total messages: 37 (28 generated)
Description was changed from ========== Load library dependencies instead of just libjingle_peerconnection_so. Older Android versions have trouble locating the library dependencies automatically. Loading them manually resolves the issue. BUG=webrtc:6751 ========== to ========== Load library dependencies instead of just libjingle_peerconnection_so. Older Android versions have trouble locating the library dependencies automatically. Loading them manually resolves the issue. BUG=webrtc:6751 ==========
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/20332) linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/18879)
Code changes looks good to me, but the bots are failing.
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Load library dependencies instead of just libjingle_peerconnection_so. Older Android versions have trouble locating the library dependencies automatically. Loading them manually resolves the issue. BUG=webrtc:6751 ========== to ========== Load library dependencies in AppRTCMobile. Older Android versions have trouble locating the library dependencies automatically. Loading them manually resolves the issue. BUG=webrtc:6751 ==========
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Because of the problem with the bots I decided just to add the libraries to AppRTCMobile. PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484905350502580,
"parent_rev": "be850e1b1de5bf046080ac1df7de67a3d6d12d1c", "commit_rev":
"3e9229045ee807dcf141168a780f59ffe067c80b"}
Message was sent while issue was closed.
Description was changed from ========== Load library dependencies in AppRTCMobile. Older Android versions have trouble locating the library dependencies automatically. Loading them manually resolves the issue. BUG=webrtc:6751 ========== to ========== Load library dependencies in AppRTCMobile. Older Android versions have trouble locating the library dependencies automatically. Loading them manually resolves the issue. BUG=webrtc:6751 Review-Url: https://codereview.webrtc.org/2635233002 Cr-Commit-Position: refs/heads/master@{#16179} Committed: https://chromium.googlesource.com/external/webrtc/+/3e9229045ee807dcf141168a7... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/external/webrtc/+/3e9229045ee807dcf141168a7...
Message was sent while issue was closed.
On 2017/01/19 14:36:46, sakal wrote: > Because of the problem with the bots I decided just to add the libraries to > AppRTCMobile. PTAL This commit crashes AppRTCMobile and my own app using this implementation on a Xperia Z5 Compact (Android 6.0.1) and Xperia S (Android 4.1.2). I recommend reverting this commit for now. On opening the CallActivity the following errors occurs: java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/org.appspot.apprtc-1/base.apk"],nativeLibraryDirectories=[/data/app/org.appspot.apprtc-1/lib/arm, /data/app/org.appspot.apprtc-1/base.apk!/lib/armeabi-v7a, /vendor/lib, /system/lib]]] couldn't find "libc++_shared.so"
Message was sent while issue was closed.
On 2017/01/20 16:26:38, ywa.ftw wrote: > On 2017/01/19 14:36:46, sakal wrote: > > Because of the problem with the bots I decided just to add the libraries to > > AppRTCMobile. PTAL > > This commit crashes AppRTCMobile and my own app using this implementation on a > Xperia Z5 Compact (Android 6.0.1) and Xperia S (Android 4.1.2). I recommend > reverting this commit for now. > > On opening the CallActivity the following errors occurs: > java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip > file > "/data/app/org.appspot.apprtc-1/base.apk"],nativeLibraryDirectories=[/data/app/org.appspot.apprtc-1/lib/arm, > /data/app/org.appspot.apprtc-1/base.apk!/lib/armeabi-v7a, /vendor/lib, > /system/lib]]] couldn't find "libc++_shared.so" Agree that this should not be required. Sami, can this workaround only be used when needed? Even in those cases, I wonder if it might be in exceptional cases, e.g a device that has had some environment changes?
Message was sent while issue was closed.
I also agree this should not be necessary but it seems some devices have buggy implementations. I created a CL catching the error. Hopefully this will make all devices happy. https://codereview.webrtc.org/2652623002/ |
