Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2635133003: Update YuvConverter to use GlTextureFrameBuffer. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update YuvConverter to use GlTextureFrameBuffer. Old implementation also had a bug where it had the framebuffer bound while changing the texture size. This causes problems on some phones. BUG=webrtc:6751 Review-Url: https://codereview.webrtc.org/2635133003 Cr-Commit-Position: refs/heads/master@{#16141} Committed: https://chromium.googlesource.com/external/webrtc/+/2fcd2dd93a4ebc4c309fbb33224da0bb6f6d0d07

Patch Set 1 #

Patch Set 2 : Make variable final. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -44 lines) Patch
M webrtc/sdk/android/api/org/webrtc/YuvConverter.java View 1 4 chunks +8 lines, -44 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-17 15:20:42 UTC) #3
magjed_webrtc
Great! lgtm
3 years, 11 months ago (2017-01-18 10:10:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2635133003/20001
3 years, 11 months ago (2017-01-18 10:27:27 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 11:21:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2fcd2dd93a4ebc4c309fbb332...

Powered by Google App Engine
This is Rietveld 408576698