Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2634973002: Do not classify error after stopping the camera as a startup failure. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, AlexG
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not classify error after stopping the camera as a startup failure. Calling event handlers when the camera is closing is safe because CameraCapturer checks if the errors are coming from the current session. Calling onFailure after camera has already started might lead to strange behavior. BUG=b/34112992 Review-Url: https://codereview.webrtc.org/2634973002 Cr-Commit-Position: refs/heads/master@{#16101} Committed: https://chromium.googlesource.com/external/webrtc/+/c117e2ed79bf1a354bd611c761fd621a80058d72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/sdk/android/api/org/webrtc/Camera2Session.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-16 12:32:25 UTC) #3
sakal
PTAL
3 years, 11 months ago (2017-01-16 12:32:26 UTC) #4
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-16 12:56:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2634973002/1
3 years, 11 months ago (2017-01-16 13:00:41 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 17:40:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c117e2ed79bf1a354bd611c76...

Powered by Google App Engine
This is Rietveld 408576698