Initiate mid-call probing even if estimated bitrate is at max configured bitrate.

Initiate mid-call probing even if estimated bitrate is at max configured bitrate.

BUG=none

Review-Url: https://codereview.webrtc.org/2634883003
Cr-Commit-Position: refs/heads/master@{#16107}
Committed: https://chromium.googlesource.com/external/webrtc/+/da5e9d04f59ed88d1db4a364ca23ac8466d7ec8b

[philipel, 2017-01-16 13:16:33]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[philipel, 2017-01-16 13:16:33]

PTAL

[stefan-webrtc, 2017-01-16 13:23:59]

lgtm

https://codereview.webrtc.org/2634883003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/probe_controller.cc (right):

https://codereview.webrtc.org/2634883003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_controller.cc:74: // The reason we
set use the variable |old_max_bitrate_pbs| is because we
-set

https://codereview.webrtc.org/2634883003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_controller.cc:91: if
(estimated_bitrate_bps_ != 0 &&
Should probably still compare with kExponentialProbingDisabled?

[stefan-webrtc, 2017-01-16 13:24:21]

May want to create a bug, especially if this will need merging.

[philipel, 2017-01-16 13:59:28]

https://codereview.webrtc.org/2634883003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/probe_controller.cc (right):

https://codereview.webrtc.org/2634883003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_controller.cc:74: // The reason we
set use the variable |old_max_bitrate_pbs| is because we
On 2017/01/16 13:23:59, stefan-webrtc wrote:
> -set

Done.

https://codereview.webrtc.org/2634883003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_controller.cc:91: if
(estimated_bitrate_bps_ != 0 &&
On 2017/01/16 13:23:59, stefan-webrtc wrote:
> Should probably still compare with kExponentialProbingDisabled?

This logic is not related to exponential probing, so it doesn't make sense to
use kExponentialProbingDisabled here.

[philipel, 2017-01-16 13:59:31]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2017-01-16 13:59:31]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2634883003/#ps20001 (title:
"Comment fix.")

[commit-bot: I haz the power, 2017-01-16 13:59:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-16 16:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 16:34:33]

Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/18812)

[philipel, 2017-01-17 09:01:44]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2017-01-17 09:01:44]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2634883003/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-01-17 09:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-17 10:08:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484643704162010,
"parent_rev": "fa5a368b3cc9625153c6f10c30dbccd70e56357c", "commit_rev":
"da5e9d04f59ed88d1db4a364ca23ac8466d7ec8b"}

[commit-bot: I haz the power, 2017-01-17 10:08:30]

Description was changed from

==========
Initiate mid-call probing even if estimated bitrate is at max configured
bitrate.

BUG=none
==========

to

==========
Initiate mid-call probing even if estimated bitrate is at max configured
bitrate.

BUG=none

Review-Url: https://codereview.webrtc.org/2634883003
Cr-Commit-Position: refs/heads/master@{#16107}
Committed:
https://chromium.googlesource.com/external/webrtc/+/da5e9d04f59ed88d1db4a364c...
==========

[commit-bot: I haz the power, 2017-01-17 10:08:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/da5e9d04f59ed88d1db4a364c...