Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2634283002:
Make sure the result is floating point in InitLowFrequencyCorrectionRanges. (Closed)
|
Created:
3 years, 11 months ago by ANdi Modified:
3 years, 7 months ago CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1, sylvestre_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMake sure the resulted operation is calculated on float basis.
BUG=webrtc:7558
Review-Url: https://codereview.webrtc.org/2634283002
Cr-Commit-Position: refs/heads/master@{#17983}
Committed: https://chromium.googlesource.com/external/webrtc/+/4ed18da9903f6fdb4a502def3e0e6f0408463940
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== make sure the result is floating point in InitLowFrequencyCorrectionRanges. BUG= ========== to ========== The bug has been discovered by running Coverity, a static analysis tool, on our mozilla-central code base. ==========
bpostelnicu@mozilla.com changed reviewers: + ossu@webrtc.org
Hi, Is this still an issue. I've unfortunately missed it. Chances are smaller this will happen again if you also send out a message once the CL is ready for review. I'll have a looks at it now.
ossu@webrtc.org changed reviewers: + aluebs@webrtc.org
The change looks good to me, but I've not enough insight to say it may not have unforeseen consequences: i.e. now possibly mapping to a one-higher bin than before. Adding aluebs@ to consider that, since he seems to have written this (or very similar) code initially.
The CQ bit was checked by ossu@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16637)
lgtm
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16670)
Great! LGTM as well. Please create a bug and link to it in the description of this CL, like so: BUG=webrtc:xxxx It's a small change but it'd be nice to track it properly. Also: it's the law. :)
On 2017/05/03 08:58:49, ossu wrote: > Great! LGTM as well. > > Please create a bug and link to it in the description of this CL, like so: > BUG=webrtc:xxxx > > It's a small change but it'd be nice to track it properly. Also: it's the law. > :) Thanks for the review, sure thing I'll add a bug and link it here.
Description was changed from ========== The bug has been discovered by running Coverity, a static analysis tool, on our mozilla-central code base. ========== to ========== Make sure the resulted operation is calculated on float basis. BUG=webrtc:7558 ==========
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493806602879800, "parent_rev":
"44116a5dc5a0c4c450700dbcebffd23875911f35", "commit_rev":
"4ed18da9903f6fdb4a502def3e0e6f0408463940"}
Message was sent while issue was closed.
Description was changed from ========== Make sure the resulted operation is calculated on float basis. BUG=webrtc:7558 ========== to ========== Make sure the resulted operation is calculated on float basis. BUG=webrtc:7558 Review-Url: https://codereview.webrtc.org/2634283002 Cr-Commit-Position: refs/heads/master@{#17983} Committed: https://chromium.googlesource.com/external/webrtc/+/4ed18da9903f6fdb4a502def3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/4ed18da9903f6fdb4a502def3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
