Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2633643003: Finalize the support for building WebRTC library for iOS with bitcode (Closed)

Created:
3 years, 11 months ago by VladimirTechMan
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Finalize the support for building WebRTC library for iOS with bitcode Initial provisioning was already done in build_ios_libs.sh to support building the WebRTC framework or static library for iOS (tvOS, watchOS) with bitcode. Still, the actual build configuration would need to be modified for each and every part of the build, including 3rd-party libs. Thus, doing that more universally, at the build/config level, would be desirable – and actually necessary to provide the intended support. The patch for enhancing the Chromium build configs with that specific option was landed in https://codereview.chromium.org/2631573002 NOTRY=True BUG=webrtc:5085 Review-Url: https://codereview.webrtc.org/2633643003 Cr-Commit-Position: refs/heads/master@{#16193} Committed: https://chromium.googlesource.com/external/webrtc/+/0fc04b74c5f358e3891b34eaf0c8e580f087a8b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
D webrtc/build/ios/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/build/ios/build_ios_libs.sh View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
VladimirTechMan
3 years, 11 months ago (2017-01-13 20:26:41 UTC) #2
kjellander_webrtc
lgtm (I updated the CL description slightly and added a BUG= reference) +kthelgason FYI
3 years, 11 months ago (2017-01-20 13:13:38 UTC) #6
kthelgason
Awesome work, thanks!
3 years, 11 months ago (2017-01-20 13:23:30 UTC) #7
kthelgason
lgtm
3 years, 11 months ago (2017-01-20 13:24:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2633643003/1
3 years, 11 months ago (2017-01-20 15:59:04 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 16:01:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0fc04b74c5f358e3891b34eaf...

Powered by Google App Engine
This is Rietveld 408576698