Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2633453002: Delete unused rtpdump code in media/base. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 11 months ago
Reviewers:
the sun, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused rtpdump code in media/base. Reading and writing RTP files is implemented elsewhere, in test/rtp_file_reader.cc and test/rtp_file_writer.cc; that code is untouched by this cl. BUG=webrtc:6974 Review-Url: https://codereview.webrtc.org/2633453002 Cr-Commit-Position: refs/heads/master@{#16046} Committed: https://chromium.googlesource.com/external/webrtc/+/61f31ee37607f5c3ba2c5930e6ab48f2b69b4c5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1059 lines) Patch
M webrtc/media/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D webrtc/media/base/rtpdump.h View 1 chunk +0 lines, -218 lines 0 comments Download
D webrtc/media/base/rtpdump.cc View 1 chunk +0 lines, -407 lines 0 comments Download
D webrtc/media/base/rtpdump_unittest.cc View 1 chunk +0 lines, -282 lines 0 comments Download
M webrtc/media/base/testutils.h View 1 chunk +0 lines, -37 lines 0 comments Download
M webrtc/media/base/testutils.cc View 2 chunks +0 lines, -112 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nisse-webrtc
PTAL. I think this code became unused when pbos deleted MediaRecorder and FileMediaEngine one and ...
3 years, 11 months ago (2017-01-12 08:49:18 UTC) #2
the sun
nice. lgtm
3 years, 11 months ago (2017-01-12 09:53:04 UTC) #3
pbos-webrtc
excellent, lgtm
3 years, 11 months ago (2017-01-12 21:45:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2633453002/1
3 years, 11 months ago (2017-01-13 07:38:28 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 13:55:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/61f31ee37607f5c3ba2c5930e...

Powered by Google App Engine
This is Rietveld 408576698