Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2632563002:
Remove the IceTransportInternal2. (Closed)
DescriptionRelanding: Remove the IceTransportInternal2.
Introduing IceTransportInternal2 is a temporary fix to switch the base
class of P2PTransportChannel to IceTransportInternal without breaking
Chromium. It is removed in this CL.
Reland this CL after Chromium doesn't depend on this.
BUG=webrtc:6951
Review-Url: https://codereview.webrtc.org/2632563002
Cr-Original-Commit-Position: refs/heads/master@{#16131}
Committed: https://chromium.googlesource.com/external/webrtc/+/c7953fa716dc26db1123bb80351d46e496792c81
Review-Url: https://codereview.webrtc.org/2632563002
Cr-Commit-Position: refs/heads/master@{#16960}
Committed: https://chromium.googlesource.com/external/webrtc/+/2c48d0c5313dee5dd5fe846eaf660cc7fa901659
Patch Set 1 #Patch Set 2 : Merge. #Messages
Total messages: 33 (23 generated)
deadbeef@webrtc.org changed reviewers: + deadbeef@webrtc.org
lgtm (after chromium CL lands)
The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zhihuang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484536219256560, "parent_rev":
"ab2e044e97dc992b4f5e46dc815e60db84d165cf", "commit_rev":
"8aaa51190e043e12b7a9acb28ff730e575d651ae"}
Message was sent while issue was closed.
Description was changed from ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. BUG=webrtc:6951 ========== to ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16083} Committed: https://chromium.googlesource.com/external/webrtc/+/8aaa51190e043e12b7a9acb28... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/8aaa51190e043e12b7a9acb28...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2630243002/ by henrikg@webrtc.org. The reason for reverting is: Broke Chromium FYI bots. See for example https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build... FAILED: obj/remoting/protocol/protocol/ice_transport_channel.obj ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/remoting/protocol/protocol/ice_transport_channel.obj.rsp /c ../../remoting/protocol/ice_transport_channel.cc /Foobj/remoting/protocol/protocol/ice_transport_channel.obj /Fd"obj/remoting/protocol/protocol_cc.pdb" e:\b\c\b\win_builder\src\remoting\protocol\ice_transport_channel.cc(186): error C2039: 'IceTransportInternal2': is not a member of 'cricket' e:\b\c\b\win_builder\src\third_party\webrtc\p2p\base\p2ptransportchannel.h(38): note: see declaration of 'cricket' e:\b\c\b\win_builder\src\remoting\protocol\ice_transport_channel.cc(186): error C2065: 'IceTransportInternal2': undeclared identifier e:\b\c\b\win_builder\src\remoting\protocol\ice_transport_channel.cc(186): error C2065: 'ice_transport': undeclared identifier e:\b\c\b\win_builder\src\remoting\protocol\ice_transport_channel.cc(187): error C2059: syntax error: 'const' e:\b\c\b\win_builder\src\remoting\protocol\ice_transport_channel.cc(187): error C2143: syntax error: missing ';' before '{' e:\b\c\b\win_builder\src\remoting\protocol\ice_transport_channel.cc(187): error C2447: '{': missing function header (old-style formal list?) .
Message was sent while issue was closed.
Description was changed from ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16083} Committed: https://chromium.googlesource.com/external/webrtc/+/8aaa51190e043e12b7a9acb28... ========== to ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16083} Committed: https://chromium.googlesource.com/external/webrtc/+/8aaa51190e043e12b7a9acb28... ==========
Description was changed from ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16083} Committed: https://chromium.googlesource.com/external/webrtc/+/8aaa51190e043e12b7a9acb28... ========== to ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. BUG=webrtc:6951 ==========
The CQ bit was checked by zhihuang@webrtc.org
The CQ bit was unchecked by zhihuang@webrtc.org
Description was changed from ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. BUG=webrtc:6951 ========== to ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. Reland this CL after Chromium doesn't depend on this. BUG=webrtc:6951 ==========
The CQ bit was checked by zhihuang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484706798763720, "parent_rev":
"bad5dadef3cf90d8ba081e7f814e913ecd2ff83d", "commit_rev":
"c7953fa716dc26db1123bb80351d46e496792c81"}
Message was sent while issue was closed.
Description was changed from ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. Reland this CL after Chromium doesn't depend on this. BUG=webrtc:6951 ========== to ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. Reland this CL after Chromium doesn't depend on this. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16131} Committed: https://chromium.googlesource.com/external/webrtc/+/c7953fa716dc26db1123bb803... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c7953fa716dc26db1123bb803...
Message was sent while issue was closed.
Description was changed from ========== Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. Reland this CL after Chromium doesn't depend on this. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16131} Committed: https://chromium.googlesource.com/external/webrtc/+/c7953fa716dc26db1123bb803... ========== to ========== Relanding: Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. Reland this CL after Chromium doesn't depend on this. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16131} Committed: https://chromium.googlesource.com/external/webrtc/+/c7953fa716dc26db1123bb803... ==========
The CQ bit was checked by zhihuang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/17970) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/23438)
The CQ bit was checked by zhihuang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org Link to the patchset: https://codereview.webrtc.org/2632563002/#ps20001 (title: "Merge.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488434012936080,
"parent_rev": "03f1d2e9e4411727df1087ce80e34fa0db022109", "commit_rev":
"2c48d0c5313dee5dd5fe846eaf660cc7fa901659"}
Message was sent while issue was closed.
Description was changed from ========== Relanding: Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. Reland this CL after Chromium doesn't depend on this. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16131} Committed: https://chromium.googlesource.com/external/webrtc/+/c7953fa716dc26db1123bb803... ========== to ========== Relanding: Remove the IceTransportInternal2. Introduing IceTransportInternal2 is a temporary fix to switch the base class of P2PTransportChannel to IceTransportInternal without breaking Chromium. It is removed in this CL. Reland this CL after Chromium doesn't depend on this. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2632563002 Cr-Original-Commit-Position: refs/heads/master@{#16131} Committed: https://chromium.googlesource.com/external/webrtc/+/c7953fa716dc26db1123bb803... Review-Url: https://codereview.webrtc.org/2632563002 Cr-Commit-Position: refs/heads/master@{#16960} Committed: https://chromium.googlesource.com/external/webrtc/+/2c48d0c5313dee5dd5fe846ea... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/2c48d0c5313dee5dd5fe846ea... |
