Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2631703002: Revert of Log audio network adapter decisions in event log. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Log audio network adapter decisions in event log. (patchset #14 id:320001 of https://codereview.webrtc.org/2559953002/ ) Reason for revert: Breaks chromium.webrtc.fyi. Original issue's description: > Log audio network adapter decisions in event log. > > BUG=webrtc:6845 > > Review-Url: https://codereview.webrtc.org/2559953002 > Cr-Commit-Position: refs/heads/master@{#16053} > Committed: https://chromium.googlesource.com/external/webrtc/+/3663681b5d05682f38e75d9eaf6049299f62fb02 TBR=minyue@webrtc.org,henrik.lundin@webrtc.org,terelius@webrtc.org,stefan@webrtc.org,solenberg@webrtc.org,michaelt@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6845 Review-Url: https://codereview.webrtc.org/2631703002 Cr-Commit-Position: refs/heads/master@{#16054} Committed: https://chromium.googlesource.com/external/webrtc/+/363a29157ad162f48c63e9d6424ff9949af59e4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -596 lines) Patch
M webrtc/logging/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 3 chunks +0 lines, -7 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.proto View 3 chunks +0 lines, -25 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 2 chunks +1 line, -9 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 4 chunks +1 line, -10 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc View 3 chunks +2 lines, -19 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc View 5 chunks +0 lines, -20 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/event_log_writer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/event_log_writer.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/event_log_writer_unittest.cc View 1 chunk +0 lines, -265 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sakal
Created Revert of Log audio network adapter decisions in event log.
3 years, 11 months ago (2017-01-13 14:51:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2631703002/1
3 years, 11 months ago (2017-01-13 14:52:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/363a29157ad162f48c63e9d6424ff9949af59e4a
3 years, 11 months ago (2017-01-13 14:52:16 UTC) #6
sakal
3 years, 11 months ago (2017-01-13 14:53:08 UTC) #7
Message was sent while issue was closed.
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%2...

../../third_party/webrtc/logging/rtc_event_log/rtc_event_log.cc: In member
function 'virtual void webrtc::RtcEventLogImpl::LogAudioNetworkAdaptation(const
webrtc::AudioNetworkAdaptor::EncoderRuntimeConfig&)':
../../third_party/webrtc/logging/rtc_event_log/rtc_event_log.cc:443:19: error:
'AUDIO_NETWORK_ADAPTATION_EVENT' is not a member of 'webrtc::rtclog::Event'
   event->set_type(rtclog::Event::AUDIO_NETWORK_ADAPTATION_EVENT);
                   ^
../../third_party/webrtc/logging/rtc_event_log/rtc_event_log.cc:444:42: error:
'class webrtc::rtclog::Event' has no member named
'mutable_audio_network_adaptation'
   auto audio_network_adaptation = event->mutable_audio_network_adaptation();

Powered by Google App Engine
This is Rietveld 408576698