Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2631423002:
Remove dependency to Chromium code from WebRTC Java code. (Closed)
|
Created:
3 years, 11 months ago by sakal Modified:
3 years, 11 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove dependency to Chromium code from WebRTC Java code.
BUG=webrtc:6996
Review-Url: https://codereview.webrtc.org/2631423002
Cr-Commit-Position: refs/heads/master@{#16122}
Committed: https://chromium.googlesource.com/external/webrtc/+/61c98e0899e129385ff12e5f16a74864f2b782d7
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Remove dependency to Chromium code from WebRTC Java code. BUG=webrtc:6996 ========== to ========== Remove dependency to Chromium code from WebRTC Java code. BUG=webrtc:6996 ==========
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/18853)
The CQ bit was checked by sakal@webrtc.org
The CQ bit was unchecked by sakal@webrtc.org
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/18862)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484663550283340, "parent_rev":
"e08b253ee0313f09d8fd85231402e01aca2d9ee1", "commit_rev":
"61c98e0899e129385ff12e5f16a74864f2b782d7"}
Message was sent while issue was closed.
Description was changed from ========== Remove dependency to Chromium code from WebRTC Java code. BUG=webrtc:6996 ========== to ========== Remove dependency to Chromium code from WebRTC Java code. BUG=webrtc:6996 Review-Url: https://codereview.webrtc.org/2631423002 Cr-Commit-Position: refs/heads/master@{#16122} Committed: https://chromium.googlesource.com/external/webrtc/+/61c98e0899e129385ff12e5f1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/61c98e0899e129385ff12e5f1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
