Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2630713002: Drop dependency to Chromium in WebRtcJniBootTest. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop dependency to Chromium in WebRtcJniBootTest. The dependency breaks a build downstream. BUG=None Review-Url: https://codereview.webrtc.org/2630713002 Cr-Commit-Position: refs/heads/master@{#16047} Committed: https://chromium.googlesource.com/external/webrtc/+/c5da08fc12faa862fbf0c34181332c32dae458a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/WebRtcJniBootTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-13 09:13:35 UTC) #3
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-13 09:17:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2630713002/1
3 years, 11 months ago (2017-01-13 12:29:46 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 13:56:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c5da08fc12faa862fbf0c3418...

Powered by Google App Engine
This is Rietveld 408576698