Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2630553003: Replace left-over ASSERTs in httpcommon.h and webrtcsession.cc. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 11 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace left-over ASSERTs in httpcommon.h and webrtcsession.cc. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2630553003 Cr-Commit-Position: refs/heads/master@{#16055} Committed: https://chromium.googlesource.com/external/webrtc/+/a9dd4a1b1180feadc8f16ca1a5173310f1f11597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M webrtc/api/webrtcsession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/httpcommon.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
3 years, 11 months ago (2017-01-13 10:25:35 UTC) #2
kwiberg-webrtc
lgtm
3 years, 11 months ago (2017-01-13 11:45:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2630553003/1
3 years, 11 months ago (2017-01-13 12:18:19 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 15:08:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a9dd4a1b1180feadc8f16ca1a...

Powered by Google App Engine
This is Rietveld 408576698