Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2628833004: Remove lint ignores and add WrongCall ignore directly to the test. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove lint ignores and add WrongCall ignore directly to the test. Also removes some unused strings from AppRTCMobile strings.xml. BUG=webrtc:6597 TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2628833004 Cr-Commit-Position: refs/heads/master@{#16033} Committed: https://chromium.googlesource.com/external/webrtc/+/bca122e0d593d76a077d6be96201fd5be2a42451

Patch Set 1 : Use annotation instead of a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M webrtc/build/android/suppressions.xml View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/res/values/strings.xml View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/sdk/android/instrumentationtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-12 10:44:29 UTC) #5
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-12 12:07:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2628833004/20001
3 years, 11 months ago (2017-01-12 13:02:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/bca122e0d593d76a077d6be96201fd5be2a42451
3 years, 11 months ago (2017-01-12 14:19:44 UTC) #11
kjellander_webrtc
3 years, 11 months ago (2017-01-20 14:26:15 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698