Stop using deprecated constraints-based version of CreateAudioSource.

Stop using deprecated constraints-based version of CreateAudioSource.

Also did some slight refactoring of the code that turns constraints
into rtc::Optionals. Used a template method to avoid code duplication,
and used the same pattern for "CopyConstraintsIntoAudioOptions" as was
being used for "CopyConstraintsIntoRtcConfiguration".

BUG=webrtc:6752
Review-Url: https://codereview.webrtc.org/2628523003
Cr-Commit-Position: refs/heads/master@{#16063}
Committed: https://chromium.googlesource.com/external/webrtc/+/fe0fd41bb96030aa69026b166d4886fc5fc757a6

[pthatcher1, 2017-01-12 23:15:25]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2017-01-12 23:15:26]

LGTM, with a suggestion to avoid some code duplication.

https://codereview.webrtc.org/2628523003/diff/1/webrtc/api/mediaconstraintsin...
File webrtc/api/mediaconstraintsinterface.cc (right):

https://codereview.webrtc.org/2628523003/diff/1/webrtc/api/mediaconstraintsin...
webrtc/api/mediaconstraintsinterface.cc:45: }
Why doesn't this use FindConstraint with a string to reduce code duplication?

if (!FindConstraint(constraints, key, &string_value, mandatory_constraints)) {
  return false;
}
return rtc::FromString(string_value, value);

[Taylor Brandstetter, 2017-01-12 23:38:06]

https://codereview.webrtc.org/2628523003/diff/1/webrtc/api/mediaconstraintsin...
File webrtc/api/mediaconstraintsinterface.cc (right):

https://codereview.webrtc.org/2628523003/diff/1/webrtc/api/mediaconstraintsin...
webrtc/api/mediaconstraintsinterface.cc:45: }
On 2017/01/12 23:15:26, pthatcher1 wrote:
> Why doesn't this use FindConstraint with a string to reduce code duplication?
> 
> if (!FindConstraint(constraints, key, &string_value, mandatory_constraints)) {
>   return false;
> }
> return rtc::FromString(string_value, value);

Great idea, not sure why I didn't notice that.

[Taylor Brandstetter, 2017-01-12 23:38:10]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-12 23:38:11]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2628523003/#ps20001 (title:
"Eliminate some code duplication.")

[commit-bot: I haz the power, 2017-01-12 23:38:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-12 23:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:43:05]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12189)

[Taylor Brandstetter, 2017-01-13 00:10:28]

deadbeef@webrtc.org changed reviewers:
+ magjed@webrtc.org

[Taylor Brandstetter, 2017-01-13 00:10:29]

magjed: Can you take a look at the JNI changes?

[magjed_webrtc, 2017-01-13 09:08:25]

On 2017/01/13 00:10:29, Taylor Brandstetter wrote:
> magjed: Can you take a look at the JNI changes?

JNI changes lgtm

[Taylor Brandstetter, 2017-01-13 18:34:12]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-13 18:34:13]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2628523003/#ps40001 (title:
"Missing bang.")

[commit-bot: I haz the power, 2017-01-13 18:34:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-13 19:47:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484332452989620,
"parent_rev": "8e814d79063c30435ef3bfa0da40661ba0846c94", "commit_rev":
"fe0fd41bb96030aa69026b166d4886fc5fc757a6"}

[commit-bot: I haz the power, 2017-01-13 19:47:59]

Description was changed from

==========
Stop using deprecated constraints-based version of CreateAudioSource.

Also did some slight refactoring of the code that turns constraints
into rtc::Optionals. Used a template method to avoid code duplication,
and used the same pattern for "CopyConstraintsIntoAudioOptions" as was
being used for "CopyConstraintsIntoRtcConfiguration".

BUG=webrtc:6752
==========

to

==========
Stop using deprecated constraints-based version of CreateAudioSource.

Also did some slight refactoring of the code that turns constraints
into rtc::Optionals. Used a template method to avoid code duplication,
and used the same pattern for "CopyConstraintsIntoAudioOptions" as was
being used for "CopyConstraintsIntoRtcConfiguration".

BUG=webrtc:6752

Review-Url: https://codereview.webrtc.org/2628523003
Cr-Commit-Position: refs/heads/master@{#16063}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fe0fd41bb96030aa69026b166...
==========

[commit-bot: I haz the power, 2017-01-13 19:48:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/fe0fd41bb96030aa69026b166...