Fix JNI reference leak in MediaCodecVideoEncoder

Fix JNI reference leak in MediaCodecVideoEncoder

We currently leak one local reference to MediaCodecVideoEncoder in
every call to MediaCodecVideoEncoderFactory::CreateVideoEncoder. After
the encoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoEncoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969
,b/34056152

Review-Url: https://codereview.webrtc.org/2627973004
Cr-Commit-Position: refs/heads/master@{#16034}
Committed: https://chromium.googlesource.com/external/webrtc/+/b66129a27efd44198e4a73a27268ae17032bb617

[magjed_webrtc, 2017-01-12 13:21:30]

Description was changed from

==========
Fix JNI reference leak in MediaCodecVideoEncoder

We currently leak one local reference to MediaCodecVideoEncoder.java in
every call to MediaCodecVideoEncoderFactory::CreateVideoEncoder. After
the encoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoEncoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=b/34056152
==========

to

==========
Fix JNI reference leak in MediaCodecVideoEncoder

We currently leak one local reference to MediaCodecVideoEncoder.java in
every call to MediaCodecVideoEncoderFactory::CreateVideoEncoder. After
the encoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoEncoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/34056152
==========

[magjed_webrtc, 2017-01-12 13:21:30]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2017-01-12 13:21:55]

Description was changed from

==========
Fix JNI reference leak in MediaCodecVideoEncoder

We currently leak one local reference to MediaCodecVideoEncoder.java in
every call to MediaCodecVideoEncoderFactory::CreateVideoEncoder. After
the encoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoEncoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/34056152
==========

to

==========
Fix JNI reference leak in MediaCodecVideoEncoder

We currently leak one local reference to MediaCodecVideoEncoder in
every call to MediaCodecVideoEncoderFactory::CreateVideoEncoder. After
the encoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoEncoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/34056152
==========

[magjed_webrtc, 2017-01-12 13:22:47]

Sami - please take a look.

[magjed_webrtc, 2017-01-12 13:22:51]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 13:23:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-12 14:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 14:34:52]

Dry run: This issue passed the CQ dry run.

[sakal, 2017-01-12 14:47:06]

lgtm

[magjed_webrtc, 2017-01-12 14:48:32]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2017-01-12 14:48:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-12 14:50:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484232512544380, "parent_rev":
"bca122e0d593d76a077d6be96201fd5be2a42451", "commit_rev":
"b66129a27efd44198e4a73a27268ae17032bb617"}

[commit-bot: I haz the power, 2017-01-12 14:51:03]

Description was changed from

==========
Fix JNI reference leak in MediaCodecVideoEncoder

We currently leak one local reference to MediaCodecVideoEncoder in
every call to MediaCodecVideoEncoderFactory::CreateVideoEncoder. After
the encoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoEncoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/34056152
==========

to

==========
Fix JNI reference leak in MediaCodecVideoEncoder

We currently leak one local reference to MediaCodecVideoEncoder in
every call to MediaCodecVideoEncoderFactory::CreateVideoEncoder. After
the encoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoEncoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/34056152

Review-Url: https://codereview.webrtc.org/2627973004
Cr-Commit-Position: refs/heads/master@{#16034}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b66129a27efd44198e4a73a27...
==========

[commit-bot: I haz the power, 2017-01-12 14:51:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b66129a27efd44198e4a73a27...