Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2627583002: Disable some filesystem tests that don't make sense on iOS. (Closed)

Created:
3 years, 11 months ago by kthelgason
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable some filesystem tests that don't make sense on iOS. BUG=webrtc:5571 NOTRY=true Review-Url: https://codereview.webrtc.org/2627583002 Cr-Commit-Position: refs/heads/master@{#15981} Committed: https://chromium.googlesource.com/external/webrtc/+/5d682ca7a1d2bb3ca7de2bbb469281e07ea85bde

Patch Set 1 #

Patch Set 2 : Enable test_support_unittests on the iOS bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M webrtc/build/ios/tests/common_tests.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/test/testsupport/fileutils_unittest.cc View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kthelgason
3 years, 11 months ago (2017-01-10 09:03:31 UTC) #2
kjellander_webrtc
lgtm You can most likely use NOTRY=True for this change (maybe fire a few other ...
3 years, 11 months ago (2017-01-10 09:38:46 UTC) #3
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-10 10:22:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2627583002/20001
3 years, 11 months ago (2017-01-10 10:58:26 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 11:00:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5d682ca7a1d2bb3ca7de2bbb4...

Powered by Google App Engine
This is Rietveld 408576698