Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2627523004: Update ice server provider response format in iOS AppRTCMobile (Closed)

Created:
3 years, 11 months ago by kthelgason
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update ice server provider response format in iOS AppRTCMobile BUG=webrtc:5963 Review-Url: https://codereview.webrtc.org/2627523004 Cr-Commit-Position: refs/heads/master@{#16050} Committed: https://chromium.googlesource.com/external/webrtc/+/cc882afdf79f5a8235887f59fcb842998a62131f

Patch Set 1 #

Patch Set 2 : pass url instead of string #

Total comments: 1

Patch Set 3 : lower similarity and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -164 lines) Patch
M webrtc/examples/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ARDAppClient.m View 5 chunks +6 lines, -23 lines 0 comments Download
D webrtc/examples/objc/AppRTCMobile/ARDCEODTURNClient.h View 1 chunk +0 lines, -18 lines 0 comments Download
D webrtc/examples/objc/AppRTCMobile/ARDCEODTURNClient.m View 1 chunk +0 lines, -66 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDTURNClient.m View 1 2 2 chunks +48 lines, -28 lines 0 comments Download
A + webrtc/examples/objc/AppRTCMobile/ARDTURNClient+Internal.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/RTCIceServer+JSON.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/RTCIceServer+JSON.m View 1 chunk +4 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kthelgason
PTAL. It's a bigger change than I expected, but it's mostly just cleaning up some ...
3 years, 11 months ago (2017-01-10 15:09:49 UTC) #2
janssonWebRTC
LGTM regarding the response format only since I'm no objective-c expert, will leave that to ...
3 years, 11 months ago (2017-01-11 09:11:58 UTC) #3
magjed_webrtc
Thanks! Looks good as far as I understand. I would like to try to review ...
3 years, 11 months ago (2017-01-11 14:40:12 UTC) #4
kthelgason
I reuploded the patch with lower similarity, so the diff is more clear now. Please ...
3 years, 11 months ago (2017-01-12 12:43:43 UTC) #5
magjed_webrtc
Great! lgtm
3 years, 11 months ago (2017-01-12 13:39:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2627523004/40001
3 years, 11 months ago (2017-01-13 08:28:27 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 13:59:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/cc882afdf79f5a8235887f59f...

Powered by Google App Engine
This is Rietveld 408576698