Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2626473004: Revert of Fix BitrateProber to match the requested bitrate more precisely (Closed)

Created:
3 years, 11 months ago by sprang_webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix BitrateProber to match the requested bitrate more precisely (patchset #4 id:60001 of https://codereview.webrtc.org/2613543003/ ) Reason for revert: Speculative revert. Linux memcheck bot started failing a lot at the time of this cl. Doesn't look related at first glance, but we don't have another lead yet. Original issue's description: > Fix BitrateProber to match the requested bitrate more precisely > > Previously BirateProber was calculating delay between probes based on > the size of the previous probe. Because of that the actual sent bitrate > can deviate greatly from the target value. With this change it uses > total number of bytes in the cluster to estimate delay before each > probe. > > BUG=webrtc:6952 > > Review-Url: https://codereview.webrtc.org/2613543003 > Cr-Commit-Position: refs/heads/master@{#15971} > Committed: https://chromium.googlesource.com/external/webrtc/+/599c5011e7569a269f5521a8c7e6ab930e7adbd5 TBR=philipel@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6952 Review-Url: https://codereview.webrtc.org/2626473004 Cr-Commit-Position: refs/heads/master@{#15979} Committed: https://chromium.googlesource.com/external/webrtc/+/ebfbc8ebfd0c9ace51353827a85fade550c04353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -81 lines) Patch
M webrtc/modules/pacing/bitrate_prober.h View 1 chunk +7 lines, -14 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 7 chunks +42 lines, -31 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober_unittest.cc View 1 chunk +14 lines, -32 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sprang_webrtc
Created Revert of Fix BitrateProber to match the requested bitrate more precisely
3 years, 11 months ago (2017-01-10 09:27:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2626473004/1
3 years, 11 months ago (2017-01-10 09:27:24 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 09:27:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ebfbc8ebfd0c9ace51353827a...

Powered by Google App Engine
This is Rietveld 408576698