Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2626203002: Rename base/analytics/ to base/numerics/ (Closed)

Created:
3 years, 11 months ago by terelius
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, zhengzhonghou_agora.io, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename base/analytics/ to base/numerics/ BUG=webrtc:6832 Review-Url: https://codereview.webrtc.org/2626203002 Cr-Commit-Position: refs/heads/master@{#16060} Committed: https://chromium.googlesource.com/external/webrtc/+/bc5d921659e8f2184dd0ff9af18ac609a6c81a4f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Include order and format #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -450 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
D webrtc/base/analytics/exp_filter.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/base/analytics/exp_filter.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/base/analytics/exp_filter_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D webrtc/base/analytics/percentile_filter.h View 1 chunk +0 lines, -115 lines 0 comments Download
D webrtc/base/analytics/percentile_filter_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
A + webrtc/base/numerics/exp_filter.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
A + webrtc/base/numerics/exp_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/base/numerics/exp_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/base/numerics/percentile_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/base/numerics/percentile_filter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/median_slope_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codec_timer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/media_opt_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/frame_dropper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
terelius
This is a straight-forward move/rename CL, but I need owner approval for various folders. mflodman: ...
3 years, 11 months ago (2017-01-12 11:22:56 UTC) #4
kwiberg-webrtc
lgtm for audio_coding
3 years, 11 months ago (2017-01-12 12:49:45 UTC) #5
sprang_webrtc
lgtm for video_coding
3 years, 11 months ago (2017-01-12 13:21:06 UTC) #6
mflodman
One include order fix, then LGTM. https://codereview.webrtc.org/2626203002/diff/1/webrtc/base/numerics/percentile_filter_unittest.cc File webrtc/base/numerics/percentile_filter_unittest.cc (right): https://codereview.webrtc.org/2626203002/diff/1/webrtc/base/numerics/percentile_filter_unittest.cc#newcode14 webrtc/base/numerics/percentile_filter_unittest.cc:14: #include "webrtc/base/numerics/percentile_filter.h" Include ...
3 years, 11 months ago (2017-01-13 13:53:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2626203002/20001
3 years, 11 months ago (2017-01-13 15:22:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/4714) linux_baremetal on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-13 15:24:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2626203002/40001
3 years, 11 months ago (2017-01-13 15:38:14 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 17:14:38 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/bc5d921659e8f2184dd0ff9af...

Powered by Google App Engine
This is Rietveld 408576698