GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

This is a first step towards it. I plan to refactor modules_unittests before continuing with this.

BUG=webrtc:6626
NOTRY=True

Review-Url: https://codereview.webrtc.org/2626163004
Cr-Commit-Position: refs/heads/master@{#16109}
Committed: https://chromium.googlesource.com/external/webrtc/+/1fd08c1e67b0cce45ddbadf660fc368cf3aac1ae

[ehmaldonado_webrtc, 2017-01-13 14:51:45]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2017-01-13 14:51:46]

This is a first step for it.
I plan to refactor modules_unittests before continuing with this.

[ehmaldonado_webrtc, 2017-01-13 14:52:00]

Description was changed from

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

BUG=
==========

to

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

BUG=webrtc:6626
==========

[ehmaldonado_webrtc, 2017-01-13 14:53:08]

Description was changed from

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

BUG=webrtc:6626
==========

to

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

This is a first step towards it. I plan to refactor modules_unittests before
continuing with this.

BUG=webrtc:6626
==========

[ehmaldonado_webrtc, 2017-01-13 14:54:07]

ehmaldonado@webrtc.org changed reviewers:
+ henrika@webrtc.org

[ehmaldonado_webrtc, 2017-01-13 14:54:07]

henrika: can you review this, please?

[henrika_webrtc, 2017-01-13 14:59:07]

I really don't know GN at all. Could you find someone who can give you better
feedback?

Thanks!

[ehmaldonado_webrtc, 2017-01-13 15:13:20]

On 2017/01/13 14:59:07, henrika_webrtc wrote:
> I really don't know GN at all. Could you find someone who can give you better
> feedback?
> 
> Thanks!

Sure :)
Do you know of anyone who does?

[kjellander_webrtc, 2017-01-14 14:41:42]

On 2017/01/13 15:13:20, ehmaldonado_webrtc wrote:
> On 2017/01/13 14:59:07, henrika_webrtc wrote:
> > I really don't know GN at all. Could you find someone who can give you
better
> > feedback?
> > 
> > Thanks!
> 
> Sure :)
> Do you know of anyone who does?

I do; LGTM. We should add a "more configs" bot for that build config when it
builds. Can you do that?

[ehmaldonado_webrtc, 2017-01-16 13:17:50]

On 2017/01/14 14:41:42, kjellander_webrtc OOO to Jan19 wrote:
> On 2017/01/13 15:13:20, ehmaldonado_webrtc wrote:
> > On 2017/01/13 14:59:07, henrika_webrtc wrote:
> > > I really don't know GN at all. Could you find someone who can give you
> better
> > > feedback?
> > > 
> > > Thanks!
> > 
> > Sure :)
> > Do you know of anyone who does?
> 
> I do; LGTM. We should add a "more configs" bot for that build config when it
> builds. Can you do that?

Sure. Still a long way to go, tho

[ehmaldonado_webrtc, 2017-01-16 13:17:55]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-01-16 13:18:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-16 17:25:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 17:25:28]

Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16738)

[ehmaldonado_webrtc, 2017-01-17 10:35:05]

Description was changed from

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

This is a first step towards it. I plan to refactor modules_unittests before
continuing with this.

BUG=webrtc:6626
==========

to

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

This is a first step towards it. I plan to refactor modules_unittests before
continuing with this.

BUG=webrtc:6626
NOTRY=True
==========

[ehmaldonado_webrtc, 2017-01-17 10:35:05]

ehmaldonado@webrtc.org changed reviewers:
- henrika@webrtc.org

[ehmaldonado_webrtc, 2017-01-17 10:35:14]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-01-17 10:35:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-17 10:37:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484649314659820, "parent_rev":
"ece0571d44a84036d696b10d4d2986944faa15da", "commit_rev":
"1fd08c1e67b0cce45ddbadf660fc368cf3aac1ae"}

[commit-bot: I haz the power, 2017-01-17 10:37:36]

Description was changed from

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

This is a first step towards it. I plan to refactor modules_unittests before
continuing with this.

BUG=webrtc:6626
NOTRY=True
==========

to

==========
GN: Refactor so that WebRTC compiles with rtc_enable_protobuf=false.

This is a first step towards it. I plan to refactor modules_unittests before
continuing with this.

BUG=webrtc:6626
NOTRY=True

Review-Url: https://codereview.webrtc.org/2626163004
Cr-Commit-Position: refs/heads/master@{#16109}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1fd08c1e67b0cce45ddbadf66...
==========

[commit-bot: I haz the power, 2017-01-17 10:37:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1fd08c1e67b0cce45ddbadf66...